Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add UserService and Implementation for register #15

Merged
merged 3 commits into from
Jul 1, 2024
Merged

chore: add UserService and Implementation for register #15

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1460a71
chore: add UserService and Implementation for register
ramesz6 Jul 1, 2024
da90dbe
fix: empty lines remove, userService now use private final repository
ramesz6 Jul 1, 2024
5450ff1
fix: indentations fix, javadoc add
ramesz6 Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions backend/src/main/java/com/greenfoxacademy/backend/services/UserService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package com.greenfoxacademy.backend.services;

import com.greenfoxacademy.backend.models.User;
import org.springframework.stereotype.Service;

@Service

Check warning on line 6 in backend/src/main/java/com/greenfoxacademy/backend/services/UserService.java

View workflow job for this annotation

GitHub Actions / build 

[testtool] reported by reviewdog 🐶
Missing a Javadoc comment.

Raw Output:
/github/workspace/./backend/src/main/java/com/greenfoxacademy/backend/services/UserService.java:6:1: warning: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck)
public interface UserService {
public void register(User newUser);

Check warning on line 8 in backend/src/main/java/com/greenfoxacademy/backend/services/UserService.java

View workflow job for this annotation

GitHub Actions / build 

[testtool] reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.

Raw Output:
/github/workspace/./backend/src/main/java/com/greenfoxacademy/backend/services/UserService.java:8:5: warning: 'method def modifier' has incorrect indentation level 4, expected level should be 2. (com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck)

markkovari marked this conversation as resolved.
Show resolved Hide resolved
}
16 changes: 16 additions & 0 deletions backend/src/main/java/com/greenfoxacademy/backend/services/UserServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
package com.greenfoxacademy.backend.services;

import com.greenfoxacademy.backend.models.User;
import com.greenfoxacademy.backend.repositories.UserRepository;
import org.springframework.stereotype.Service;

@Service

Check warning on line 7 in backend/src/main/java/com/greenfoxacademy/backend/services/UserServiceImpl.java

View workflow job for this annotation

GitHub Actions / build 

[testtool] reported by reviewdog 🐶
Missing a Javadoc comment.

Raw Output:
/github/workspace/./backend/src/main/java/com/greenfoxacademy/backend/services/UserServiceImpl.java:7:1: warning: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck)
public class UserServiceImpl implements UserService {
UserRepository userRepository;

Check warning on line 9 in backend/src/main/java/com/greenfoxacademy/backend/services/UserServiceImpl.java

View workflow job for this annotation

GitHub Actions / build 

[testtool] reported by reviewdog 🐶
'member def type' has incorrect indentation level 4, expected level should be 2.

Raw Output:
/github/workspace/./backend/src/main/java/com/greenfoxacademy/backend/services/UserServiceImpl.java:9:5: warning: 'member def type' has incorrect indentation level 4, expected level should be 2. (com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck)
markkovari marked this conversation as resolved.
Show resolved Hide resolved


markkovari marked this conversation as resolved.
Show resolved Hide resolved
@Override

Check warning on line 12 in backend/src/main/java/com/greenfoxacademy/backend/services/UserServiceImpl.java

View workflow job for this annotation

GitHub Actions / build 

[testtool] reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.

Raw Output:
/github/workspace/./backend/src/main/java/com/greenfoxacademy/backend/services/UserServiceImpl.java:12:5: warning: 'method def modifier' has incorrect indentation level 4, expected level should be 2. (com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck)
public void register(User newUser) {
userRepository.save(newUser);

Check warning on line 14 in backend/src/main/java/com/greenfoxacademy/backend/services/UserServiceImpl.java

View workflow job for this annotation

GitHub Actions / build 

[testtool] reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.

Raw Output:
/github/workspace/./backend/src/main/java/com/greenfoxacademy/backend/services/UserServiceImpl.java:14:9: warning: 'method def' child has incorrect indentation level 8, expected level should be 4. (com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck)
}

Check warning on line 15 in backend/src/main/java/com/greenfoxacademy/backend/services/UserServiceImpl.java

View workflow job for this annotation

GitHub Actions / build 

[testtool] reported by reviewdog 🐶
'method def rcurly' has incorrect indentation level 4, expected level should be 2.

Raw Output:
/github/workspace/./backend/src/main/java/com/greenfoxacademy/backend/services/UserServiceImpl.java:15:5: warning: 'method def rcurly' has incorrect indentation level 4, expected level should be 2. (com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck)
}
Loading