Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs,build] Update build.sh to stop on error, update docs on mtools, flex, bison #2075

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

ghaerr
Copy link
Owner

@ghaerr ghaerr commented Oct 15, 2024

Enhance ./build.sh to stop on error (discussed in #2042).

Update documentation on mtools, flex, bison (not needed).

Cleans up atoi.c, atol.c.

@ghaerr ghaerr merged commit 3f755dd into master Oct 15, 2024
3 checks passed
@ghaerr ghaerr deleted the docs branch October 15, 2024 04:41
@toncho11
Copy link
Contributor

Maybe releasing version 8.1 before these boot optimizations is a good idea?

@ghaerr
Copy link
Owner Author

ghaerr commented Oct 15, 2024

Why not include the boot layout changes? Going backwards and producing binaries to upload is a lot of work. We might be better off with more frequent releases anyways if I didn't worry about organizing all the changes in a ChangeLog each time. The build process could probably be automated on my end and let Github produce the ChangeLog (I don't prefer its output, but its automated).

With the introduction of #2074 yesterday, it may be possible for Github to automatically build all images with the CI, although that would slow down the individual PR submission/acceptance by quite a bit, which is already 3mins * 2 = 6 mins. (Sounds small but when you have 4-5 PRs in queue, one sits around waiting for quite a bit).

There is no code difference, only the mfs program was enhanced to allow specification of the first-used programs to be laid out on the image first. Having floppy boot time cut in half is huge, if it were not included in v0.8.1, then why not just release a v0.8.2 with it immediately afterwards? (There is not any actual boot image optimization code compiled in by default, only measurement tools default OFF).

I was also hoping to solve the problem of not being able to produce PC-98 images on Debian 12.7, for which #2074 is also a fix.

@toncho11
Copy link
Contributor

In my mind it is about what is tested. New stuff is untested. For me, even a single line of change can produce a bug.

@ghaerr
Copy link
Owner Author

ghaerr commented Oct 16, 2024

In my mind it is about what is tested. New stuff is untested. For me, even a single line of change can produce a bug.

Agreed, you're right. I've turned off boot optimization in #2078, in preparation for a cut of v0.8.1 without any major changes.

@tyama501, are you OK with cutting v0.8.1 now?

@tyama501
Copy link
Contributor

Quick tested v0.8.1 released pc-98 image on the emulator.
Looks great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants