Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[directfd] Update DF driver for bugs on multiple opens #2087

Merged
merged 1 commit into from
Oct 25, 2024
Merged

[directfd] Update DF driver for bugs on multiple opens #2087

merged 1 commit into from
Oct 25, 2024

Conversation

ghaerr
Copy link
Owner

@ghaerr ghaerr commented Oct 25, 2024

Adds per-drive globals (amongst all the other globals) to fix problems identified by @Mellvik in Mellvik/TLVC#95 when a second DF device is opened prior to any I/O requests received for the first device (or vice-versa).

Other changes include:

  • Don't auto-probe floppy on pre-AT systems
  • Group "dual" globals together at top of driver so easy to see
  • Don't display first auto-probe message (as either result or next probe is always displayed)
  • Changed "implied seek" printk to debug only
  • Changed "auto-detected" message to just display floppy type
  • Always disable interrupts before accessing 8237 DMA controller (for shared flip-flop, actually just removes FIXME comment)
  • Fixes small bug disabling next request when invalid FDC command seen (wouldn't happen anyways)

@ghaerr ghaerr merged commit 3a662d6 into master Oct 25, 2024
1 check passed
@ghaerr ghaerr deleted the df5 branch October 25, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant