[kernel,libc] Fix precision timer get_ptime #2088
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @Mellvik's fantastic job at testing, using and now identifying a major bug in the precision timer
get_ptime
routine in Mellvik/TLVC#97, this PR fixes it.The original precision timing calculation was found to be up to 10ms inaccurate possibly 50% of the time - whenever the PIT countdown timer decreased to a value less than its original value and wrapped across zero (i.e. a hardware timer interrupt).
The original routine should have been unit tested, instead of "eyeballing" its output using QEMU. The current fix has been unit tested using the following, as well as re-eyeballed under QEMU:
For now, all code has
#if 1
including both the new/fixed and original code, for possible comparison purposes. This will be removed after having been verified on real hardware.Thank you @Mellvik for your excellent debugging work on this, well done!!!!