Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): dropdown component #124

Closed
wants to merge 3 commits into from

Conversation

72mins
Copy link

@72mins 72mins commented Dec 23, 2024

Type-safe dropdown component following the styleguide and colorscheme of the other components.

Allows for both single option select as with a normal dropdown and for link navigation which solves issue #97.

Switching between option select and link navigation is done automatically based on the options array sent to the dropdown as a prop. The placeholders, size, theme, etc.. are also customizable via props as with other components.

Currently, the dropdown is not implemented on the download page, cause I want @mitchellh and @BrandonRomano to check it out for any styling issues or other bugs.

Copy link

vercel bot commented Dec 23, 2024

@72mins is attempting to deploy a commit to the Ghostty team on Vercel, but is not a member of this team. To resolve this issue, you can:

  • Make your repository public. Collaboration is free for open source and public repositories.
  • Add @72mins as a member. A Pro subscription is required to access Vercel's collaborative features.
    • If you're the owner of the team, click here and add @72mins as a member.
    • If you're the user who initiated this build request, click here to request access.
    • If you're already a member of the Ghostty team, make sure that your Vercel account is connected to your GitHub account.

To read more about collaboration on Vercel, click here.

@BrandonRomano
Copy link
Member

I'll have some time tomorrow to properly check this one out. Sorry for the delay on this one!

@BrandonRomano
Copy link
Member

@72mins - I wanted to clone this down to try out; but I don't have permissions to your repository. I think that this is because you made this PR when the repo was still private & there's some permission issues related to that.

Could you re-open this PR from a public repository so I can check it out?

Sorry for the hiccup I know you have been waiting a bit for a review here!

@72mins
Copy link
Author

72mins commented Dec 28, 2024

No worries, I'll get that pushed back up tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants