Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new column "Global Progress" percentage per achivement #420

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vlad-p-929
Copy link

I think adding this extra info eliminates some extra steps for users. For these who'd like to use this tool in a 'smart' way to not open everything in a bulk, but with some understandable logic.
GlobalProgress

bool nameMatches = searchTerms.All(term => def.Name.IndexOf(term, StringComparison.OrdinalIgnoreCase) >= 0);
bool descriptionMatches = searchTerms.All(term => def.Description.IndexOf(term, StringComparison.OrdinalIgnoreCase) >= 0);

if (!nameMatches && !descriptionMatches)
Copy link
Author

@vlad-p-929 vlad-p-929 Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I missed that it was added here, I've slightly reworked Search to be able to search with spaces, like

image

image

image

I'll revert this one if needed.

@vlad-p-929
Copy link
Author

vlad-p-929 commented Sep 24, 2024

I just discovered that my changes are not working perfectly. RequestGlobalAchievementPercentages() is asynchronous, and when running the built .exe, the first time you open the game, the GlobalAchievementPercentages haven't finished loading. You have to close the game window and reopen it to see the percentages.

To make it work properly, after void OnUserStatsReceived(APITypes.UserStatsReceived param), I need another callback like void OnGlobalAchievementPercentagesReceived(APITypes.GlobalAchievementPercentagesReceived param).

I'm trying to dig deeper into the codebase since I'm not familiar with it yet.

UPD: Moved this._SteamClient.SteamUserStats.RequestGlobalAchievementPercentages(); to ctor before client.CreateAndRegisterCallback<API.Callbacks.UserStatsReceived>() and it did a trick
UPDD: Nah, I was just lucky a couple of times in a row and seems Task finished its work earlier :C

@Fan4eGGG
Copy link

Fan4eGGG commented Oct 6, 2024

Searching by achievements would be perfect!
And a couple of localizations could be added as well

@ghost
Copy link

ghost commented Nov 10, 2024

This is a feature that I always wonder why it isn't implemented already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants