-
-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A new column "Global Progress" percentage per achivement #420
base: master
Are you sure you want to change the base?
Conversation
bool nameMatches = searchTerms.All(term => def.Name.IndexOf(term, StringComparison.OrdinalIgnoreCase) >= 0); | ||
bool descriptionMatches = searchTerms.All(term => def.Description.IndexOf(term, StringComparison.OrdinalIgnoreCase) >= 0); | ||
|
||
if (!nameMatches && !descriptionMatches) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just discovered that my changes are not working perfectly. To make it work properly, after I'm trying to dig deeper into the codebase since I'm not familiar with it yet. UPD: Moved |
Searching by achievements would be perfect! |
This is a feature that I always wonder why it isn't implemented already |
I think adding this extra info eliminates some extra steps for users. For these who'd like to use this tool in a 'smart' way to not open everything in a bulk, but with some understandable logic.