Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of buffers instead of strings with Redis #24

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

caitisgreat
Copy link

redis & redis-parser defines the use of Buffer in Redis, but disqueue-node isn't configured correctly to use buffers and always assumes we don't want to use them. This pull request allows a user of this library to use buffers as a return type.

From redis-parser docs
https://github.com/NodeRedis/node-redis-parser#options

returnBuffers: boolean; optional, defaults to false

but then redis uses this

From redis docs
https://github.com/NodeRedis/node-redis#options-object-properties

return_buffers false If set to true, then all replies will be sent to callbacks as Buffers instead of Strings.

@caitisgreat caitisgreat changed the title Allow use of Redis buffers instead of strings Allow use of buffers instead of strings with Redis Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant