Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WeakRef in layout node parent to avoid cyclic strong references #26

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Use WeakRef in layout node parent to avoid cyclic strong references #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3265346
Use WeakRef in layout node parent to avoid cyclic strong references
gilzoide Nov 12, 2023
fbe2fec
Instantiate empty WeakRef to avoid having to check for null
gilzoide Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion addons/dockable_container/layout_node.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,13 @@ class_name DockableLayoutNode
extends Resource
## Base class for DockableLayout tree nodes

var parent: DockableLayoutSplit = null
var parent: DockableLayoutSplit:
get:
return _parent_ref.get_ref()
set(value):
_parent_ref = weakref(value)

var _parent_ref := WeakRef.new()


func emit_tree_changed() -> void:
Expand Down
Loading