Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elf: parse library from symbol versioning table #693

Merged
merged 7 commits into from
Jun 9, 2024

Conversation

robbje
Copy link
Contributor

@robbje robbje commented Jun 7, 2024

This change parses the library name for a dynamic symbol from the ELF symbol versioning table and removes a // TODO

src/read/elf/file.rs Outdated Show resolved Hide resolved
src/read/elf/file.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is getting close, just some style changes now.

src/read/elf/file.rs Outdated Show resolved Hide resolved
src/read/elf/file.rs Outdated Show resolved Hide resolved
src/read/elf/version.rs Outdated Show resolved Hide resolved
src/read/elf/version.rs Outdated Show resolved Hide resolved
@robbje
Copy link
Contributor Author

robbje commented Jun 9, 2024

Thanks for the reviews.

@philipc philipc merged commit 7b58f78 into gimli-rs:master Jun 9, 2024
10 checks passed
mcbegamerxx954 pushed a commit to mcbegamerxx954/object that referenced this pull request Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants