Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build/elf: handle .annobin.notes string section #735

Merged
merged 1 commit into from
Oct 10, 2024
Merged

build/elf: handle .annobin.notes string section #735

merged 1 commit into from
Oct 10, 2024

Conversation

philipc
Copy link
Contributor

@philipc philipc commented Oct 5, 2024

Closes #734

@philipc philipc mentioned this pull request Oct 5, 2024
Closed
@javierhonduco
Copy link

Thanks! Confirming that this no longer returns an Err on some test binaries I have tried.

javierhonduco
javierhonduco approved these changes Oct 9, 2024
View reviewed changes
Copy link

@javierhonduco javierhonduco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a maintainer but LGTM :)

@philipc
Copy link
Contributor Author

philipc commented Oct 10, 2024

Added a regression test.

@philipc philipc merged commit b25fb7f into gimli-rs:master Oct 10, 2024
10 checks passed
@philipc philipc deleted the issue-734 branch October 10, 2024 06:13
@javierhonduco
Copy link

Thanks so much! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierhonduco javierhonduco javierhonduco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when parsing "non standard" string table (.annobin.notes.)
2 participants
@philipc @javierhonduco