Merge pull request #530 from gini/PP-689_Atruvia-Accessibility---Land…

…scape_Problem Pp 689 atruvia accessibility landscape problem
gini · Aug 14, 2024 · 8e8aedf · 8e8aedf
2 parents 2bc2f35 + 25fcef6
commit 8e8aedf
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 31 deletions.
diff --git a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/CaptureFlowFragment.kt b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/CaptureFlowFragment.kt
@@ -1,5 +1,6 @@
 package net.gini.android.bank.sdk.capture
 
+import android.content.pm.ActivityInfo
 import android.os.Bundle
 import android.view.LayoutInflater
 import android.view.View
@@ -29,6 +30,7 @@ import net.gini.android.capture.GiniCaptureFragmentDirections
 import net.gini.android.capture.GiniCaptureFragmentListener
 import net.gini.android.capture.camera.CameraFragmentListener
 import net.gini.android.capture.internal.util.CancelListener
+import net.gini.android.capture.internal.util.ContextHelper
 import net.gini.android.capture.network.model.GiniCaptureCompoundExtraction
 import net.gini.android.capture.network.model.GiniCaptureSpecificExtraction
 import net.gini.android.capture.tracking.useranalytics.UserAnalytics
@@ -110,7 +112,7 @@ class CaptureFlowFragment(private val openWithDocument: Document? = null) :
     override fun onDestroy() {
         super.onDestroy()
         if (!didFinishWithResult && !willBeRestored) {
-            captureFlowFragmentListener.onFinishedWithResult(CaptureResult.Cancel)
+            finishWithResult(CaptureResult.Cancel)
         }
     }
 
@@ -159,14 +161,13 @@ class CaptureFlowFragment(private val openWithDocument: Document? = null) :
                     }
 
                     else -> {
-                        finishWithResult(result)
+                        finishWithResult(interceptSuccessResult(result).toCaptureResult())
                     }
                 }
             }
 
             else -> {
-                didFinishWithResult = true
-                captureFlowFragmentListener.onFinishedWithResult(result.toCaptureResult())
+                finishWithResult(result.toCaptureResult())
             }
         }
     }
@@ -195,16 +196,17 @@ class CaptureFlowFragment(private val openWithDocument: Document? = null) :
                     GiniCaptureFragmentDirections.toSkontoFragment(data = skontoData)
                 )
             } catch (e: Exception) {
-                finishWithResult(result)
+                finishWithResult(interceptSuccessResult(result).toCaptureResult())
             }
-        } else {
-            finishWithResult(result)
         }
     }
 
-    private fun finishWithResult(result: CaptureSDKResult.Success) {
+    private fun finishWithResult(result: CaptureResult) {
+        if (!ContextHelper.isTablet(requireContext())) {
+            requireActivity().requestedOrientation = ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED
+        }
         didFinishWithResult = true
-        captureFlowFragmentListener.onFinishedWithResult(interceptSuccessResult(result).toCaptureResult())
+        captureFlowFragmentListener.onFinishedWithResult(result)
         trackSdkClosedEvent(UserAnalyticsScreen.Analysis)
     }
 
@@ -237,37 +239,30 @@ class CaptureFlowFragment(private val openWithDocument: Document? = null) :
         specificExtractions: Map<String, GiniCaptureSpecificExtraction>,
         compoundExtractions: Map<String, GiniCaptureCompoundExtraction>
     ) {
-        didFinishWithResult = true
-        captureFlowFragmentListener.onFinishedWithResult(
-            CaptureResult.Success(
-                specificExtractions,
-                compoundExtractions,
-                emptyList()
-            )
-        )
+        finishWithResult(CaptureResult.Success(
+            specificExtractions,
+            compoundExtractions,
+            emptyList()
+        ))
     }
 
 
     override fun onPayInvoiceWithSkonto(
         specificExtractions: Map<String, GiniCaptureSpecificExtraction>,
         compoundExtractions: Map<String, GiniCaptureCompoundExtraction>
     ) {
-        didFinishWithResult = true
-        captureFlowFragmentListener.onFinishedWithResult(
-            CaptureResult.Success(
-                specificExtractions,
-                compoundExtractions,
-                emptyList()
-            )
-        )
+        finishWithResult(CaptureResult.Success(
+            specificExtractions,
+            compoundExtractions,
+            emptyList()
+        ))
     }
 
 
     override fun onCancelFlow() {
         val popBackStack = navController.popBackStack()
         if (!popBackStack) {
-            didFinishWithResult = true
-            captureFlowFragmentListener.onFinishedWithResult(CaptureResult.Cancel)
+            finishWithResult(CaptureResult.Cancel)
         }
     }
 

diff --git a/...java/net/gini/android/capture/tracking/useranalytics/BufferedUserAnalyticsEventTracker.kt b/...java/net/gini/android/capture/tracking/useranalytics/BufferedUserAnalyticsEventTracker.kt
@@ -27,7 +27,7 @@ internal class BufferedUserAnalyticsEventTracker(
     private val userProperties: Queue<Set<UserAnalyticsUserProperty>> = LinkedList()
     private val events: Queue<Pair<UserAnalyticsEvent, Set<UserAnalyticsEventProperty>>> =
         LinkedList()
-    private lateinit var amplitude: AmplitudeUserAnalyticsEventTracker
+    private var amplitude: AmplitudeUserAnalyticsEventTracker? = null
 
     fun setPlatformTokens(
         vararg tokens: UserAnalytics.AnalyticsApiKey,
@@ -46,8 +46,8 @@ internal class BufferedUserAnalyticsEventTracker(
                         networkRequestsManager = networkRequestsManager,
                         uniqueIdProvider = uniqueIdProvider
                     )
-                    amplitude.startRepeatingJob()
-                    eventTrackers.add(amplitude)
+                    amplitude?.startRepeatingJob()
+                    amplitude?.let { eventTrackers.add(it) }
 
                     LOG.debug("Amplitude Initialized")
                 }
@@ -90,7 +90,7 @@ internal class BufferedUserAnalyticsEventTracker(
     }
 
     override fun flushEvents() {
-        amplitude.flushEvents()
+        amplitude?.flushEvents()
     }
 
     private fun trySendEvents() {