Skip to content

Commit

Permalink
ci: Remove jacoco test coverage gradle tasks from github workflows
Browse files Browse the repository at this point in the history
- Removed gradle tasks because with AGP 8, jacoco tasks were not supported

PIA-3211
  • Loading branch information
abolfazlimahdi committed Aug 3, 2023
1 parent 0115659 commit 937ee51
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 27 deletions.
42 changes: 24 additions & 18 deletions .github/workflows/capture-sdk.check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,18 @@ jobs:
name: capture-sdk-unit-test-results
path: capture-sdk/sdk/build/reports/tests

- name: create unit test coverage report
run: ./gradlew capture-sdk:sdk:jacocoTestDebugUnitTestReport

- name: archive unit test coverage report
if: always()
uses: actions/upload-artifact@v3
with:
name: capture-sdk-unit-test-coverage
path: capture-sdk/sdk/build/jacoco/jacocoHtml
# should be investigated later, right now does not work with AGP 8
# read this article for some help: https://about.codecov.io/blog/code-coverage-for-android-development-using-kotlin-jacoco-github-actions-and-codecov/
#
# - name: create unit test coverage report
# run: ./gradlew capture-sdk:sdk:jacocoTestDebugUnitTestReport
#
# - name: archive unit test coverage report
# if: always()
# uses: actions/upload-artifact@v3
# with:
# name: capture-sdk-unit-test-coverage
# path: capture-sdk/sdk/build/jacoco/jacocoHtml

default-network-test:
runs-on: ubuntu-latest
Expand All @@ -82,15 +85,18 @@ jobs:
name: capture-sdk-default-network-unit-test-results
path: capture-sdk/default-network/build/reports/tests

- name: create unit test coverage report
run: ./gradlew capture-sdk:default-network:jacocoTestDebugUnitTestReport

- name: archive unit test coverage report
if: always()
uses: actions/upload-artifact@v3
with:
name: capture-sdk-default-network-unit-test-coverage
path: capture-sdk/default-network/build/jacoco/jacocoHtml
# should be investigated later, right now does not work with AGP 8
# read this article for some help: https://about.codecov.io/blog/code-coverage-for-android-development-using-kotlin-jacoco-github-actions-and-codecov/
#
# - name: create unit test coverage report
# run: ./gradlew capture-sdk:default-network:jacocoTestDebugUnitTestReport
#
# - name: archive unit test coverage report
# if: always()
# uses: actions/upload-artifact@v3
# with:
# name: capture-sdk-default-network-unit-test-coverage
# path: capture-sdk/default-network/build/jacoco/jacocoHtml

default-network-instrumented-test:
runs-on: macos-latest
Expand Down
21 changes: 12 additions & 9 deletions .github/workflows/health-api-library.check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,18 @@ jobs:
name: health-api-library-unit-test-results
path: health-api-library/library/build/reports/tests

- name: create unit test coverage report
run: ./gradlew health-api-library:library:jacocoTestDebugUnitTestReport

- name: archive unit test coverage report
if: always()
uses: actions/upload-artifact@v3
with:
name: health-api-library-unit-test-coverage
path: health-api-library/library/build/jacoco/jacocoHtml
# should be investigated later, right now does not work with AGP 8
# read this article for some help: https://about.codecov.io/blog/code-coverage-for-android-development-using-kotlin-jacoco-github-actions-and-codecov/
#
# - name: create unit test coverage report
# run: ./gradlew health-api-library:library:jacocoTestDebugUnitTestReport
#
# - name: archive unit test coverage report
# if: always()
# uses: actions/upload-artifact@v3
# with:
# name: health-api-library-unit-test-coverage
# path: health-api-library/library/build/jacoco/jacocoHtml

instrumented-test:
runs-on: macos-latest
Expand Down

0 comments on commit 937ee51

Please sign in to comment.