refactor(merchant-sdk): Fix failing tests

Will move test cases from `ReviewViewModelTest` to `ReviewComponentTest` EC-74
gini · Jul 19, 2024 · f2a409b · f2a409b
1 parent d76eccd
commit f2a409b
Show file tree

Hide file tree

Showing 4 changed files with 531 additions and 882 deletions.
diff --git a/...sdk/src/test/java/net/gini/android/merchant/sdk/integratedFlow/PaymentFlowFragmentTest.kt b/...sdk/src/test/java/net/gini/android/merchant/sdk/integratedFlow/PaymentFlowFragmentTest.kt
@@ -39,7 +39,7 @@ class PaymentFlowFragmentTest {
         giniMerchant = mockk<GiniMerchant>(relaxed = true)
         every { giniMerchant!!.eventsFlow } returns MutableStateFlow(mockk(relaxed = true))
         every { giniMerchant!!.paymentFlow } returns MutableStateFlow(mockk(relaxed = true))
-        every { giniMerchant!!.getPaymentReviewFragment("1234", any()) } returns mockk(relaxed = true)
+//        every { giniMerchant!!.getPaymentReviewFragment("1234", any()) } returns mockk(relaxed = true)
 
         paymentComponent = mockk<PaymentComponent>(relaxed = true)
         every { paymentComponent!!.selectedPaymentProviderAppFlow } returns MutableStateFlow(mockk(relaxed = true))
@@ -64,7 +64,7 @@ class PaymentFlowFragmentTest {
         every { paymentFlowViewModel!!.paymentNextStep } returns MutableSharedFlow()
         val fragment = PaymentFragment.newInstance(
             giniMerchant = giniMerchant!!,
-            documentId = "1234",
+            paymentDetails = mockk(relaxed = true),
             paymentFlowConfiguration = mockk(relaxed = true),
             viewModelFactory = viewModelFactory
         )
@@ -85,17 +85,16 @@ class PaymentFlowFragmentTest {
         every { paymentFlowViewModel!!.paymentFlowConfiguration!!.shouldHandleErrorsInternally } returns false
         every { paymentFlowViewModel!!.paymentFlowConfiguration!!.shouldShowReviewFragment } returns true
         every { paymentFlowViewModel!!.paymentFlowConfiguration!!.isAmountFieldEditable } returns false
-        every { paymentFlowViewModel!!.giniMerchant!!.getFragment(any(), any()) } returns mockk(relaxed = true)
+        every { paymentFlowViewModel!!.giniMerchant!!.getFragment("", "", "", "") } returns mockk(relaxed = true)
         every { paymentFlowViewModel!!.paymentNextStep } returns MutableSharedFlow()
         every { paymentFlowViewModel!!.giniMerchant.eventsFlow } returns MutableStateFlow(mockk(relaxed = true))
         every { paymentFlowViewModel!!.giniMerchant.paymentFlow } returns MutableStateFlow(mockk(relaxed = true))
         every { paymentFlowViewModel!!.paymentComponent!!.selectedPaymentProviderAppFlow } returns MutableStateFlow(
             mockk(relaxed = true)
         )
-        val documentId = "1234"
         val fragment = PaymentFragment.newInstance(
             giniMerchant = giniMerchant!!,
-            documentId = documentId,
+            paymentDetails = mockk(relaxed = true),
             paymentFlowConfiguration = PaymentFlowConfiguration(shouldShowReviewFragment = true),
             viewModelFactory = viewModelFactory
         )
@@ -105,7 +104,7 @@ class PaymentFlowFragmentTest {
         }
 
         // When
-        fragment.handlePayFlow(documentId)
+        fragment.handlePayFlow()
 
         // Then
         verify { fragment.showReviewBottomDialog() }
@@ -120,10 +119,9 @@ class PaymentFlowFragmentTest {
         every { paymentFlowViewModel!!.paymentFlowConfiguration!!.shouldHandleErrorsInternally } returns false
         every { paymentFlowViewModel!!.paymentFlowConfiguration!!.shouldShowReviewFragment } returns false
         every { paymentFlowViewModel!!.paymentFlowConfiguration!!.isAmountFieldEditable } returns false
-        val documentId = "1234"
         val fragment = PaymentFragment.newInstance(
             giniMerchant = giniMerchant!!,
-            documentId = documentId,
+            paymentDetails = mockk(relaxed = true),
             paymentFlowConfiguration = PaymentFlowConfiguration(shouldShowReviewFragment = false),
             viewModelFactory = viewModelFactory
         )
@@ -133,7 +131,7 @@ class PaymentFlowFragmentTest {
         }
 
         // When
-        fragment.handlePayFlow(documentId)
+        fragment.handlePayFlow()
 
         // Then
         verify { paymentFlowViewModel!!.onPaymentButtonTapped(any()) }

diff --git a/...dk/src/test/java/net/gini/android/merchant/sdk/integratedFlow/PaymentFlowViewModelTest.kt b/...dk/src/test/java/net/gini/android/merchant/sdk/integratedFlow/PaymentFlowViewModelTest.kt
@@ -101,7 +101,6 @@ class PaymentFlowViewModelTest {
         // Given
         val viewModel = PaymentFlowViewModel(
             paymentComponent = paymentComponent!!,
-            documentId = "1234",
             paymentFlowConfiguration = null,
             giniMerchant = giniMerchant!!,
             giniPaymentManager = GiniPaymentManager(giniMerchant)
@@ -119,7 +118,6 @@ class PaymentFlowViewModelTest {
         // Given
         val viewModel = PaymentFlowViewModel(
             paymentComponent = paymentComponent!!,
-            documentId = "1234",
             paymentFlowConfiguration = null,
             giniMerchant = giniMerchant!!,
             giniPaymentManager = GiniPaymentManager(giniMerchant)
@@ -141,7 +139,6 @@ class PaymentFlowViewModelTest {
         // Given
         val viewModel = PaymentFlowViewModel(
             paymentComponent = paymentComponent!!,
-            documentId = "1234",
             paymentFlowConfiguration = null,
             giniMerchant = giniMerchant!!,
             giniPaymentManager = GiniPaymentManager(giniMerchant)
@@ -160,7 +157,6 @@ class PaymentFlowViewModelTest {
         // Given
         val viewModel = PaymentFlowViewModel(
             paymentComponent = paymentComponent!!,
-            documentId = "1234",
             paymentFlowConfiguration = null,
             giniMerchant = giniMerchant!!,
             giniPaymentManager = GiniPaymentManager(giniMerchant)
@@ -176,7 +172,6 @@ class PaymentFlowViewModelTest {
         coEvery { giniPayment!!.onPayment(any(), any()) } coAnswers {  }
         val viewModel = PaymentFlowViewModel(
             paymentComponent = paymentComponent!!,
-            documentId = "1234",
             paymentFlowConfiguration = null,
             giniMerchant = giniMerchant!!,
             giniPaymentManager = giniPayment!!
@@ -186,20 +181,4 @@ class PaymentFlowViewModelTest {
         viewModel.onPayment()
         coVerify(exactly = 1) { giniPayment!!.onPayment(any(), any()) }
     }
-
-    @Test
-    fun `forwards load document to giniMerchant`() = runTest {
-        // Given
-        val viewModel = PaymentFlowViewModel(
-            paymentComponent = paymentComponent!!,
-            documentId = "1234",
-            paymentFlowConfiguration = null,
-            giniMerchant = giniMerchant!!,
-            giniPaymentManager = giniPayment!!
-        )
-
-        // Then
-        viewModel.loadPaymentDetails()
-        coVerify { giniMerchant!!.setDocumentForReview("1234") }
-    }
 }