From ff6cd5ad05028229ced584152e7dc77c2668a14f Mon Sep 17 00:00:00 2001
From: Mahdi Abolfazli <mahdi.abolfazli@gini.net>
Date: Fri, 23 Aug 2024 16:42:26 +0200
Subject: [PATCH] feat(bank-sdk): Finalize Skonto strings

PP-669
---
 .../bank/sdk/capture/skonto/SkontoFragment.kt |  2 +-
 .../sdk/src/main/res/values-en/strings.xml    | 28 +++++++++----------
 bank-sdk/sdk/src/main/res/values/strings.xml  |  8 +++---
 3 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/skonto/SkontoFragment.kt b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/skonto/SkontoFragment.kt
index 7b968d30e..0e8a3d119 100644
--- a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/skonto/SkontoFragment.kt
+++ b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/skonto/SkontoFragment.kt
@@ -1041,7 +1041,7 @@ private fun ScreenReadyStatePreview() {
 
 private fun Float.formatAsDiscountPercentage(): String {
     val value = BigDecimal(this.toString()).setScale(2, RoundingMode.HALF_UP)
-    return "${value.toString().trimEnd('0').trimEnd('.')} %"
+    return "${value.toString().trimEnd('0').trimEnd('.')}%"
 }
 
 private val previewState = SkontoFragmentContract.State.Ready(
diff --git a/bank-sdk/sdk/src/main/res/values-en/strings.xml b/bank-sdk/sdk/src/main/res/values-en/strings.xml
index 9a0ac876c..08aaf0fa8 100644
--- a/bank-sdk/sdk/src/main/res/values-en/strings.xml
+++ b/bank-sdk/sdk/src/main/res/values-en/strings.xml
@@ -41,47 +41,47 @@
     <string name="gbs_help_online_shops_text">We are currently focused on the most popular online merchants in the market. More retailers will be added in the future.</string>
     <string name="gbs_articles">Articles</string>
     <!-- region Skonto -->
-    <string name="gbs_skonto_screen_title">Discount</string>
+    <string name="gbs_skonto_screen_title">Skonto discount</string>
     <!--   region Section Invoice Scan -->
     <string name="gbs_skonto_section_invoice_preview_title">Invoice</string>
     <string name="gbs_skonto_invoice_section_preview_subtitle">Tap to view</string>
     <!--   endregion  -->
     <!--   region Section Discount -->
-    <string name="gbs_skonto_section_discount_title">With discount</string>
+    <string name="gbs_skonto_section_discount_title">With Skonto discount</string>
     <string name="gbs_skonto_section_discount_hint_label_enabled">  •  Active</string>
-    <string name="gbs_skonto_section_discount_info_banner_normal_message">Pay in %1$s: %2$s discount</string>
-    <string name="gbs_skonto_section_discount_info_banner_pay_today_message">Pay today: %1$s discount</string>
-    <string name="gbs_skonto_section_discount_info_banner_pay_cash_message">A %1$s discount is possible for cash payment within %2$s</string>
+    <string name="gbs_skonto_section_discount_info_banner_normal_message">Pay in %1$s: %2$s Skonto discount</string>
+    <string name="gbs_skonto_section_discount_info_banner_pay_today_message">Pay today: %1$s Skonto discount</string>
+    <string name="gbs_skonto_section_discount_info_banner_pay_cash_message">Pay in cash within the next %2$s days and receive a %1$s Skonto discount</string>
     <string name="gbs_skonto_section_discount_info_banner_date_expired_message">The %1$s discount has expired</string>
     <string name="gbs_skonto_section_discount_field_amount_hint">Final amount</string>
     <string name="gbs_skonto_section_discount_field_due_date_hint">Expiry date</string>
     <!--   endregion -->
     <!--   region Section Without Discount -->
-    <string name="gbs_skonto_section_without_discount_title">Without discount</string>
+    <string name="gbs_skonto_section_without_discount_title">Without Skonto discount</string>
     <string name="gbs_skonto_section_without_discount_hint_label_enabled">  •  Active</string>
     <string name="gbs_skonto_section_without_discount_field_amount_hint">Full amount</string>
     <!--   endregion -->
     <!--   region Footer -->
     <string name="gbs_skonto_section_footer_title">Total</string>
-    <string name="gbs_skonto_section_footer_label_discount">%1$s discount</string>
+    <string name="gbs_skonto_section_footer_label_discount">%1$s Skonto discount</string>
     <string name="gbs_skonto_section_footer_label_save">Save %1$s</string>
     <string name="gbs_skonto_section_footer_continue_button_text">Proceed</string>
     <!--   endregion -->
     <!--   region InfoDialog -->
-    <string name="gbs_skonto_section_info_dialog_pay_today_message">A discount is indicated on this invoice, it will expire after today.</string>
-    <string name="gbs_skonto_section_info_dialog_pay_cash_message">A discount is indicated on this invoice, but it can only be used for cash deposit through a bank terminal.</string>
-    <string name="gbs_skonto_section_info_dialog_date_expired_message">You could have paid this invoice with a %1$s cash discount, but the discount period has already expired.</string>
-    <string name="gbs_skonto_section_info_dialog_ok_button_text">Got it</string>
+    <string name="gbs_skonto_section_info_dialog_pay_today_message">A Skonto discount can be applied to this invoice, it will expire after today.</string>
+    <string name="gbs_skonto_section_info_dialog_pay_cash_message">A Skonto discount can be applied to this invoice, exclusively for payments in cash.</string>
+    <string name="gbs_skonto_section_info_dialog_date_expired_message">This invoice contained a discount period which has unfortunately expired.</string>
+    <string name="gbs_skonto_section_info_dialog_ok_button_text">Understood</string>
     <!--   endregion -->
     <!--   region Skonto help -->
     <string name="gbs_skonto_help_title">Help</string>
     <string name="gbs_skonto_help_save_money_title">Save money by paying promptly</string>
-    <string name="gbs_skonto_help_save_money_text">Many companies offer cash discounts, which are discounts for paying bills within a specified time frame. With our new feature, you can now:</string>
-    <string name="gbs_skonto_help_item_capture_invoice">Use your camera to capture invoices with cash discounts</string>
+    <string name="gbs_skonto_help_save_money_text">Many companies offer Skonto discounts, which are discounts for paying bills within a specified time frame. With our new feature, you can now:</string>
+    <string name="gbs_skonto_help_item_capture_invoice">Use your camera to capture invoices with Skonto discounts</string>
     <string name="gbs_skonto_help_item_identify_discount">Immediately identify discounted amounts and due dates</string>
     <string name="gbs_skonto_help_item_adjust_payment_details">Approve or adjust payment details</string>
     <string name="gbs_skonto_help_item_pay_promptly">Save money by paying promptly</string>
-    <string name="gbs_skonto_help_footer_text">Snap a photo of your invoice and the app will automatically calculate the cash discount. Just review the details, confirm, and enjoy the savings!</string>
+    <string name="gbs_skonto_help_footer_text">Take a photo of your invoice and the app will automatically calculate the Skonto discount. Just review the details, confirm, and enjoy the savings!</string>
     <!--   endregion -->
     <!-- endregion -->
 </resources>
diff --git a/bank-sdk/sdk/src/main/res/values/strings.xml b/bank-sdk/sdk/src/main/res/values/strings.xml
index 043292b0c..7a50a755a 100644
--- a/bank-sdk/sdk/src/main/res/values/strings.xml
+++ b/bank-sdk/sdk/src/main/res/values/strings.xml
@@ -44,14 +44,14 @@
     <string name="gbs_skonto_screen_title">Skonto</string>
     <!--   region Section Invoice Scan -->
     <string name="gbs_skonto_section_invoice_preview_title">Rechnung</string>
-    <string name="gbs_skonto_invoice_section_preview_subtitle">Tippen Sie hier zur Ansicht</string>
+    <string name="gbs_skonto_invoice_section_preview_subtitle">Zur Ansicht hier tippen</string>
     <!--   endregion  -->
     <!--   region Section Discount -->
     <string name="gbs_skonto_section_discount_title">Mit Skonto</string>
     <string name="gbs_skonto_section_discount_hint_label_enabled">  •  Aktiviert</string>
     <string name="gbs_skonto_section_discount_info_banner_normal_message">Zahlung in %1$s: %2$s Skonto</string>
     <string name="gbs_skonto_section_discount_info_banner_pay_today_message">Zahlung heute: %1$s Skonto</string>
-    <string name="gbs_skonto_section_discount_info_banner_pay_cash_message">%1$s Skonto sind bei Barzahlung innerhalb von %2$s möglich</string>
+    <string name="gbs_skonto_section_discount_info_banner_pay_cash_message">Zahlen Sie diese Rechnung innerhalb von %2$s Tagen in bar und Sie erhalten %1$s Skonto</string>
     <string name="gbs_skonto_section_discount_info_banner_date_expired_message">Die %1$s Skonto sind abgelaufen</string>
     <string name="gbs_skonto_section_discount_field_amount_hint">Betrag nach Abzug</string>
     <string name="gbs_skonto_section_discount_field_due_date_hint">Ablaufdatum Skonto</string>
@@ -68,8 +68,8 @@
     <string name="gbs_skonto_section_footer_continue_button_text">Zahlung fortsetzen</string>
     <!--   endregion -->
     <!--   region InfoDialog -->
-    <string name="gbs_skonto_section_info_dialog_pay_today_message">In dieser Rechnung ist ein Skonto enthalten – die Frist läuft heute ab.</string>
-    <string name="gbs_skonto_section_info_dialog_pay_cash_message">Von dieser Rechnung können Sie einen Skontobetrag abziehen, wenn Sie die Rechnung an einem Bankterminal mit Bareinzahlung bezahlen.</string>
+    <string name="gbs_skonto_section_info_dialog_pay_today_message">Von dieser Rechnung kann ein Skontobetrag abgezogen werden – die Frist läuft heute ab.</string>
+    <string name="gbs_skonto_section_info_dialog_pay_cash_message">Von dieser Rechnung können Sie einen Skontobetrag abziehen, wenn Sie diese in bar bezahlen.</string>
     <string name="gbs_skonto_section_info_dialog_date_expired_message">Diese Rechnung hätten Sie mit %1$s Skonto bezahlen können, die Skontofrist ist jedoch bereits abgelaufen.</string>
     <string name="gbs_skonto_section_info_dialog_ok_button_text">Verstanden</string>
     <!--   endregion -->