Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pia 3211 upgrade to androd gradle plugin 8 #333

Merged
merged 5 commits into from
Aug 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/bank-api-library.check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: avd cache
Expand Down Expand Up @@ -91,7 +91,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run checkstyle
Expand All @@ -112,7 +112,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run pmd
Expand All @@ -133,7 +133,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run android lint
Expand All @@ -154,7 +154,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run detekt
Expand All @@ -175,7 +175,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run ktlint
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/bank-api-library.docs.build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: setup python
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/bank-api-library.docs.release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: setup python
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/bank-api-library.release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: setup ruby
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/bank-sdk.check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run unit tests
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: avd cache
Expand Down Expand Up @@ -129,7 +129,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: build debug screen api example app
Expand Down Expand Up @@ -169,7 +169,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run android lint
Expand All @@ -190,7 +190,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run detekt
Expand All @@ -211,7 +211,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run ktlint
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/bank-sdk.docs.build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: setup python
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/bank-sdk.docs.release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: setup python
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/bank-sdk.release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: setup ruby
Expand Down
60 changes: 33 additions & 27 deletions .github/workflows/capture-sdk.check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run unit tests
Expand All @@ -49,15 +49,18 @@ jobs:
name: capture-sdk-unit-test-results
path: capture-sdk/sdk/build/reports/tests

- name: create unit test coverage report
run: ./gradlew capture-sdk:sdk:jacocoTestDebugUnitTestReport

- name: archive unit test coverage report
if: always()
uses: actions/upload-artifact@v3
with:
name: capture-sdk-unit-test-coverage
path: capture-sdk/sdk/build/jacoco/jacocoHtml
# should be investigated later, right now does not work with AGP 8
# read this article for some help: https://about.codecov.io/blog/code-coverage-for-android-development-using-kotlin-jacoco-github-actions-and-codecov/
#
# - name: create unit test coverage report
# run: ./gradlew capture-sdk:sdk:jacocoTestDebugUnitTestReport
#
# - name: archive unit test coverage report
# if: always()
# uses: actions/upload-artifact@v3
# with:
# name: capture-sdk-unit-test-coverage
# path: capture-sdk/sdk/build/jacoco/jacocoHtml

default-network-test:
runs-on: ubuntu-latest
Expand All @@ -69,7 +72,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run unit tests
Expand All @@ -82,15 +85,18 @@ jobs:
name: capture-sdk-default-network-unit-test-results
path: capture-sdk/default-network/build/reports/tests

- name: create unit test coverage report
run: ./gradlew capture-sdk:default-network:jacocoTestDebugUnitTestReport

- name: archive unit test coverage report
if: always()
uses: actions/upload-artifact@v3
with:
name: capture-sdk-default-network-unit-test-coverage
path: capture-sdk/default-network/build/jacoco/jacocoHtml
# should be investigated later, right now does not work with AGP 8
# read this article for some help: https://about.codecov.io/blog/code-coverage-for-android-development-using-kotlin-jacoco-github-actions-and-codecov/
#
# - name: create unit test coverage report
# run: ./gradlew capture-sdk:default-network:jacocoTestDebugUnitTestReport
#
# - name: archive unit test coverage report
# if: always()
# uses: actions/upload-artifact@v3
# with:
# name: capture-sdk-default-network-unit-test-coverage
# path: capture-sdk/default-network/build/jacoco/jacocoHtml

default-network-instrumented-test:
runs-on: macos-latest
Expand All @@ -102,7 +108,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: avd cache
Expand Down Expand Up @@ -158,7 +164,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: build debug screen api example app
Expand Down Expand Up @@ -198,7 +204,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run checkstyle
Expand All @@ -219,7 +225,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run pmd
Expand All @@ -240,7 +246,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run android lint
Expand All @@ -261,7 +267,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run detekt
Expand All @@ -282,7 +288,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run ktlint
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/capture-sdk.docs.build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: setup python
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/capture-sdk.docs.release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: setup python
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/capture-sdk.release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: setup ruby
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/core-api-library.check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: avd cache
Expand Down Expand Up @@ -82,7 +82,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run checkstyle
Expand All @@ -103,7 +103,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run pmd
Expand All @@ -124,7 +124,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run android lint
Expand All @@ -145,7 +145,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run detekt
Expand All @@ -166,7 +166,7 @@ jobs:
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: run ktlint
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/core-api-library.release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'gradle'

- name: setup ruby
Expand Down
Loading