Ipc 160 customize review screen #387
Conversation
… to match design
- cleanup `styles` file
There was a problem hiding this comment.
Great work! Some minor changes are needed.
Please also merge ipc-health-sdk-update into this branch. It will fix the tests.
I also left some observations that could be taken care of in a comment in the ticket. We can talk about them tomorrow.
- Removed layout related properties from `style` and moved them into the layout itself - Removed unused styles - Removed drag handle from `ghs_fragment_review` IPC-160
… visible - Remove focus from any input field which might be in focus when tapping `Payment` button - Fix new iban not being validated on change IPC-160
| if (prevPaymentDetails != null && prevPaymentDetails.iban != paymentDetails.iban) { | ||
| nonEmptyValidationMessages.remove(ValidationMessage.InvalidIban) | ||
| nonEmptyValidationMessages.addAll(validateIban(paymentDetails.iban).filterIsInstance<ValidationMessage.InvalidIban>()) |
There was a problem hiding this comment.
[Clarification] I am interested in why you added the IBAN revalidation here. I saw it caused two tests to fail so we intentionally did not revalidate the IBAN here:
I checked iOS and there validation is also repeated only on pay button press. So we need to have a good reason to change this behaviour on Android.
There was a problem hiding this comment.
Hi, I saw in this comment https://ginis.atlassian.net/browse/IPC-160?focusedCommentId=23915 that the IBAN validation error appears when the field is no longer in focus - this was not happening when I tested, this being the reason I added the revalidation.
I can take it out and leave it as is so we match iOS implementation and keep the tests from failing.
ghs_fragment_reviewscreen to match Figma design.colors.xml,dimens.xmlandstyles.xmla bit.