Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(health-sdk): Keep same pager height on configuration change in `R… #403

Merged

Conversation

danicretu
Copy link
Contributor

…eviewFragment`

IPC-201

@@ -214,7 +215,6 @@ class ReviewFragment private constructor(
indicator.isVisible = pages.size > 1
pager.isUserInputEnabled = pages.size > 1
})
removePagerConstraint()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Note] Removed this because it was already being called before in onViewCreated.

Copy link
Contributor

@a-szotyori a-szotyori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@danicretu danicretu merged commit be5d4a6 into ipc-health-sdk-update Mar 25, 2024
12 checks passed
@danicretu danicretu deleted the IPC-201-keep-pager-height-review-fragment branch March 25, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants