fix(health-sdk): Fix Share With flow broken when clients pop backst…
#474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack after getting payment request callback - Added a broadcast receiver to intercept taps on the system share sheet - Move sending of `OpenBankState.Success` to after user picks an external app to share to - Drawback is that the `OpenBankState.Success` event is not shared if the user dismisses the share sheet - but then I guess it's not of interest to the client to know that the `paymentRequest` was created, but not finalised IPC-290
…te to NoAction non-cancellable This makes sure that the `openBankState` flow is reset to `PaymentState.NoAction` also when the `ReviewViewModel`'s scope is cancelled due to the client dimissing the `ReviewFragment` when they receive `PaymentState.Success`. IPC-290
a-szotyori
reviewed
Jul 1, 2024
There was a problem hiding this comment.
Nice work, I just left a suggestion and pushed a small fix because the openBankState flow was not reset to PaymentState.NoAction when the ReviewFragmant was dismissed (its ReviewViewModel's scope was cancelled which lead to also cancelling the coroutine that resets the openBankState).
health-sdk/sdk/src/main/java/net/gini/android/health/sdk/review/ReviewFragment.kt
Outdated
Show resolved
Hide resolved
|
a-szotyori
approved these changes
Jul 1, 2024
danicretu
deleted the
IPC-290--Share-with-flow-broken-when-client-devs-receive-the-payment-request-id-and-dismiss-the-Payment-Review-Screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ack after getting payment request callback
OpenBankState.Successto after user picks an external app to share toOpenBankState.Successevent is not emitted if the user dismisses the share sheet - but then I guess it's not of interest to the client to know that thepaymentRequestwas created, but not finalisedIPC-290