-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pm 86 upgrade agp 8 4 2_CI #480
Conversation
Old roboelectric lib doesn't support sdk 34, so some unit tests fails PM-68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Eugene! The workflows should relaunch by editing the PR description. Our workflows have a PR edited trigger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks great! Please don't merge yet. We need to do QA on this first.
You can ask Daniela how to upload and share Bank SDK example app and Health SDK example app builds with AppCenter or I can brief you on Monday.
e648b04
to
6a7727f
Compare
b202995
to
1e1fe23
Compare
Quality Gate passedIssues Measures |
Hi, @GeraltRiv, I changed the target branch to Oh and please use the ticket id of the ticket itself (not its parent ticket) in the branch name. So this branch name should have used PM-85. Since this branch also contains changes for PM-92 the branch name then should contain both ids: Also I just noticed that the ticket id's in the comments are PM-68 and not PM-86. 🙈 Please make the following changes:
You can use rebase freely inside your feature branches to update the commit messages. |
Oh and also some additional |
Please ignore my last comment. I just saw your comment in the ticket. |
I create new PR twice, because after changes to yml, it refuse to run all build checks.
I'm not sure if it is a bug, @a-szotyori maybe you know more about this?
Fix ci