Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pm 86 upgrade agp 8 4 2_CI #480

Closed
wants to merge 11 commits into from
Closed

Conversation

GeraltRiv
Copy link
Contributor

@GeraltRiv GeraltRiv commented Jul 3, 2024

I create new PR twice, because after changes to yml, it refuse to run all build checks.
I'm not sure if it is a bug, @a-szotyori maybe you know more about this?

Fix ci

@GeraltRiv GeraltRiv requested a review from a-szotyori July 3, 2024 11:41
Copy link
Contributor

@a-szotyori a-szotyori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Eugene! The workflows should relaunch by editing the PR description. Our workflows have a PR edited trigger.

.github/workflows/bank-api-library.check.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@a-szotyori a-szotyori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks great! Please don't merge yet. We need to do QA on this first.

You can ask Daniela how to upload and share Bank SDK example app and Health SDK example app builds with AppCenter or I can brief you on Monday.

@a-szotyori a-szotyori requested a review from danicretu July 5, 2024 08:51
@GeraltRiv GeraltRiv changed the title Pm 86 upgrade agp 8 4 2 Pm 86 upgrade agp 8 4 2_CI Jul 5, 2024
@GeraltRiv GeraltRiv changed the title Pm 86 upgrade agp 8 4 2_CI Pm 86 upgrade agp 8 4 2 Jul 5, 2024
@GeraltRiv GeraltRiv changed the title Pm 86 upgrade agp 8 4 2 Pm 86 upgrade agp 8 4 2_CI Jul 5, 2024
@GeraltRiv GeraltRiv changed the title Pm 86 upgrade agp 8 4 2_CI Pm 86 upgrade agp 8 4 2 Jul 5, 2024
@GeraltRiv GeraltRiv changed the title Pm 86 upgrade agp 8 4 2 Pm 86 upgrade agp 8 4 2_CI Jul 5, 2024
@GeraltRiv GeraltRiv changed the title Pm 86 upgrade agp 8 4 2_CI Pm 86 upgrade agp 8 4 2 Jul 5, 2024
@GeraltRiv GeraltRiv changed the title Pm 86 upgrade agp 8 4 2 Pm 86 upgrade agp 8 4 2_CI Jul 5, 2024
@GeraltRiv GeraltRiv changed the title Pm 86 upgrade agp 8 4 2_CI Pm 86 upgrade agp 8 4 2 Jul 5, 2024
@GeraltRiv GeraltRiv changed the title Pm 86 upgrade agp 8 4 2 Pm 86 upgrade agp 8 4 2_CI Jul 5, 2024
Copy link

sonarcloud bot commented Jul 5, 2024

@a-szotyori a-szotyori changed the base branch from main to PM-86-android-15 July 8, 2024 07:45
@a-szotyori
Copy link
Contributor

a-szotyori commented Jul 8, 2024

Hi, @GeraltRiv, I changed the target branch to PM-86-android-15 to collect there all changes related Android 15.

Oh and please use the ticket id of the ticket itself (not its parent ticket) in the branch name. So this branch name should have used PM-85. Since this branch also contains changes for PM-92 the branch name then should contain both ids: PM-85-PM-92-...

Also I just noticed that the ticket id's in the comments are PM-68 and not PM-86. 🙈

Please make the following changes:

  • update the branch name to start with PM-85-PM-92-....
  • rewrite all commit messages to refer to the correct ticket ids.
  • close this PR and open a new one for the new branch name and use PM-86-android-15 as the merge target.

You can use rebase freely inside your feature branches to update the commit messages.

@a-szotyori
Copy link
Contributor

Oh and also some additional android lint builds need those pesky test parameters 🙈

@a-szotyori
Copy link
Contributor

Please ignore my last comment. I just saw your comment in the ticket.

@GeraltRiv GeraltRiv closed this Jul 8, 2024
@a-szotyori a-szotyori deleted the PM-86_Upgrade_AGP_8_4_2 branch August 12, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants