feat(capture-sdk) Add inform "qr code not available" message #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-szotyori
suggested changes
Aug 26, 2024
capture-sdk/sdk/src/main/res/layout/gc_detection_error_layout.xml
Outdated
Show resolved
Hide resolved
capture-sdk/sdk/src/main/res/layout/gc_detection_error_layout.xml
Outdated
Show resolved
Hide resolved
capture-sdk/sdk/src/main/res/layout-sw600dp-land/gc_fragment_camera.xml
Outdated
Show resolved
Hide resolved
capture-sdk/sdk/src/main/res/layout-sw600dp/gc_fragment_camera.xml
Outdated
Show resolved
Hide resolved
a-szotyori
suggested changes
Aug 27, 2024
There was a problem hiding this comment.
Sorry for requesting more changes, but I noticed some more UI differences:
- "Body2" font style is not used
- positioning on tablets is not aligned with the bottom of the frame (white corners)
- inner padding should be 8dp on phones and 16dp on tablets (you can view the distances in Figma with the option (⌥) button)
- drop shadow is missing (if not possible or too complicated to show it back to API Level 21, then only show from a more recent API level)
I made these screenshots to compare design (left) and implementation (right):
| android:background="@drawable/gc_detection_error_background" | ||
| xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:app="http://schemas.android.com/apk/res-auto"> | ||
| <TextView |
There was a problem hiding this comment.
[Request] Please use style="@style/GiniCaptureTheme.Typography.Body2" for the text.
| android:text="@string/gc_detection_error_layout_description"/> | ||
|
|
||
|
|
||
| <TextView |
There was a problem hiding this comment.
[Request] Also here please use style="@style/GiniCaptureTheme.Typography.Body2".
|
a-szotyori
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PP-143