Bac 1531 spike for adding data to http headers on mobile side #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out file - Add `generateUploadMetadata` function to `Document` class - Add extra header field to `DocumentMetadata` to be sent forward BAC-1531
…dd to headers of `createPartialDocument` request BAC-1531
a-szotyori
suggested changes
Aug 26, 2024
...t-network/src/main/java/net/gini/android/capture/network/GiniCaptureDefaultNetworkService.kt
Outdated
Show resolved
Hide resolved
...t-network/src/main/java/net/gini/android/capture/network/GiniCaptureDefaultNetworkService.kt
Outdated
Show resolved
Hide resolved
core-api-library/library/src/main/java/net/gini/android/core/api/DocumentMetadata.java
Outdated
Show resolved
Hide resolved
capture-sdk/sdk/src/main/java/net/gini/android/capture/util/UploadMetadata.kt
Outdated
Show resolved
Hide resolved
|
a-szotyori
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Awesome! Please upload a build to App Center and share it in the ticket. I will inform backend that they can use it for sending upload metadata headers to the Pay API. Once they confirm that it works we can then move BAC-1531 to done and move on with ticket BAC-894 BAC-893 to finalize the feature.
What do you think of creating a branch for BAC-894 BAC-893 and setting that one as the target branch for this PR? Then when work is continued with BAC-894 BAC-893 we have a branch for it and once we are done we can merge it into "main".
danicretu
changed the base branch from
main
to
BAC-894-Add-data-we-add-to-jpeg-exif-also-to-request-headers
a-szotyori
changed the base branch from
BAC-894-Add-data-we-add-to-jpeg-exif-also-to-request-headers
to
BAC-893-Add-data-we-add-to-jpeg-exif-also-to-request-headers
danicretu
merged commit af16041
into
BAC-893-Add-data-we-add-to-jpeg-exif-also-to-request-headers
117 checks passed
danicretu
deleted the
BAC-1531-Spike-for-adding-data-to-HTTP-Headers-on-mobile-side
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.