Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(capture-sdk) Add gini payment QR #556

Merged
merged 9 commits into from
Sep 10, 2024
Merged

Conversation

GeraltRiv
Copy link
Contributor

Added possibility to detect https://payment.gini.net/* qr codes. This feature can't be disabled EC-46

Added possibility to detect https://payment.gini.net/* qr codes. This feature can't be disabled
EC-46
@GeraltRiv GeraltRiv changed the title feature(capture-sdk) Add gini payment QR feature(capture-sdk) Add gini payment QR Aug 29, 2024
@GeraltRiv GeraltRiv changed the title feature(capture-sdk) Add gini payment QR feature(capture-sdk) Add gini payment QR Aug 29, 2024
Copy link
Contributor

@a-szotyori a-szotyori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good and I just have a clarification questions (and saw a small typo).

a-szotyori and others added 5 commits September 2, 2024 16:30
…eData` JSON, if no payment data

The Pay API expects the `paymentdata` field to be excluded when there is no payment data.
The `paymentdata` field is added only if there is at least one payment data.

EC-46
Copy link

sonarcloud bot commented Sep 3, 2024

Copy link
Contributor

@a-szotyori a-szotyori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@GeraltRiv GeraltRiv merged commit 81371b4 into main Sep 10, 2024
17 checks passed
@zladzeyka zladzeyka deleted the EC-46_Gini_Paymen_QrCode branch September 25, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants