-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pipeline): update monenfant #370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jolie reprise, c'est plus concis et clair (meme si le reste de la méthode reste le foutoir)
coordonnees__commune AS "commune", | ||
NULL AS "code_insee", | ||
CAST(NULL AS FLOAT) AS "longitude", | ||
CAST(NULL AS FLOAT) AS "latitude", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah tiens on avait lat/lon avant mais plus maintenant, dommage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes :/
- dbt_utils.not_empty_string | ||
- name: nom | ||
- dbt_utils.not_null_proportion: | ||
at_least: 0.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intéressant, pourquoi le choix de ce seuil ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
par simplicité je n'ai gardé que 2 seuils : 0.1 et 0.5
0.5 c'est pour dire que le champ est un minimum exploitable sans mettre une valeur trop haute pour éviter de casse tous les 4 matins
0.1 pour dire que ça n'est pas nul... en réalité ça pourrait être not_null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay :) ça me posait la question de documenter les seuils qque part si un jour on veut adapter / généraliser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tout à fait, on peut ajouter ça à la doc des tests dbt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on peut prévoir 30 min semaine pro pour adapter ce document
No description provided.