communications: don't send emails to inactive users

itou/communications/dispatch/email.py

@@ -42,5 +42,7 @@ def send(self):
                 logger.info("Send email copy to admin, admin_count=%d", len(admins))
                 for admin in admins:
                     self.__class__(admin, self.structure, self.user, **self.context).send()
+        if not self.user.is_active:
+            return
         if self.should_send():
             self.build().send()

tests/communications/test_dispatch.py

@@ -292,6 +292,13 @@ def test_method_send_for_employer_that_left_his_company(
             " ne fait plus partie de votre structure." in mailoutbox[1].body
         )
 
+    def test_method_send_for_inactive_user(self, email_notification, django_capture_on_commit_callbacks, mailoutbox):
+        self.user.is_active = False
+        self.user.save()
+        with django_capture_on_commit_callbacks(execute=True):
+            email_notification(self.user, self.organization).send()
+        assert len(mailoutbox) == 0
+
 
 class TestProfiledNotification:
     def setup_method(self):