Skip to content

Commit

Permalink
Remove apply buttons on filters views
Browse files Browse the repository at this point in the history
JavaScript is required in order to login, stop pretending pages can be
accessed without JavaScript.
  • Loading branch information
francoisfreitag committed Apr 8, 2024
1 parent 2a00397 commit 6be3537
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 29 deletions.
1 change: 0 additions & 1 deletion itou/static/js/approvals_filters.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@ function submitFiltersForm() {
$("#js-job-applications-filters-form").submit();
}
$("#js-job-applications-filters-form :input").change(submitFiltersForm);
$("#js-job-applications-filters-apply-button").hide();
1 change: 0 additions & 1 deletion itou/static/js/job_applications_filters.js

This file was deleted.

4 changes: 0 additions & 4 deletions itou/templates/apply/list_for_job_seeker.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@
{% include "apply/includes/job_applications_filters/statut.html" %}
<hr>
{% include "apply/includes/job_applications_filters/dates.html" %}
<button id="js-job-applications-filters-apply-button" class="btn btn-block btn-primary mt-3" aria-label="Appliquer les filtres">
Appliquer
</button>
</div>
</form>
</div>
Expand All @@ -44,5 +41,4 @@
{% block script %}
{{ block.super }}
<script src='{% static "js/htmx_compat.js" %}'></script>
<script src='{% static "js/job_applications_filters.js" %}'></script>
{% endblock %}
4 changes: 0 additions & 4 deletions itou/templates/apply/list_for_prescriber.html
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@
{% include "apply/includes/job_applications_filters/eligibility_validated.html" %}
{% include "apply/includes/job_applications_filters/criteria.html" %}
{% include "apply/includes/job_applications_filters/departments.html" %}
<button id="js-job-applications-filters-apply-button" class="btn btn-block btn-primary mt-3" aria-label="Appliquer les filtres">
Appliquer
</button>
</div>
</form>
</div>
Expand All @@ -56,6 +53,5 @@
{{ block.super }}
<!-- Needed to use Select2MultipleWidget. -->
{{ filters_form.media.js }}
<script src='{% static "js/job_applications_filters.js" %}'></script>
<script src='{% static "js/htmx_compat.js" %}'></script>
{% endblock %}
4 changes: 0 additions & 4 deletions itou/templates/apply/list_for_siae.html
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@ <h2>{{ siae.display_name }}</h2>
{% include "apply/includes/job_applications_filters/dates.html" %}
{% include "apply/includes/job_applications_filters/selected_jobs.html" %}
{% include "apply/includes/job_applications_filters/sender.html" %}
<button id="js-job-applications-filters-apply-button" class="btn btn-block btn-primary mt-3" aria-label="Appliquer les filtres">
Appliquer
</button>
</div>
</form>
</div>
Expand All @@ -63,5 +60,4 @@ <h2>{{ siae.display_name }}</h2>
<!-- Needed to use Select2MultipleWidget. -->
{{ filters_form.media.js }}
<script src='{% static "js/htmx_compat.js" %}'></script>
<script src='{% static "js/job_applications_filters.js" %}'></script>
{% endblock %}
3 changes: 0 additions & 3 deletions itou/templates/approvals/list.html
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@
<legend>Fin du parcours en IAE</legend>
{% bootstrap_field filters_form.expiry layout="inline" %}
</fieldset>
<button id="js-job-applications-filters-apply-button" class="btn btn-block btn-primary mt-3" aria-label="Appliquer les filtres">
Appliquer
</button>
</div>
</form>
</div>
Expand Down
12 changes: 0 additions & 12 deletions tests/www/apply/__snapshots__/test_list.ambr
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,6 @@
</fieldset>


<button aria-label="Appliquer les filtres" class="btn btn-block btn-primary mt-3" id="js-job-applications-filters-apply-button">
Appliquer
</button>
</div>
</form>
</div>
Expand Down Expand Up @@ -433,9 +430,6 @@

</fieldset>

<button aria-label="Appliquer les filtres" class="btn btn-block btn-primary mt-3" id="js-job-applications-filters-apply-button">
Appliquer
</button>
</div>
</form>
</div>
Expand Down Expand Up @@ -630,9 +624,6 @@

</fieldset>

<button aria-label="Appliquer les filtres" class="btn btn-block btn-primary mt-3" id="js-job-applications-filters-apply-button">
Appliquer
</button>
</div>
</form>
</div>
Expand Down Expand Up @@ -814,9 +805,6 @@

</fieldset>

<button aria-label="Appliquer les filtres" class="btn btn-block btn-primary mt-3" id="js-job-applications-filters-apply-button">
Appliquer
</button>
</div>
</form>
</div>
Expand Down

0 comments on commit 6be3537

Please sign in to comment.