From 6be3537f4964a9349f984c9e14abea6d25048458 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois=20Freitag?= <mail@franek.fr>
Date: Mon, 8 Apr 2024 17:32:56 +0200
Subject: [PATCH] Remove apply buttons on filters views

JavaScript is required in order to login, stop pretending pages can be
accessed without JavaScript.
---
 itou/static/js/approvals_filters.js           |  1 -
 itou/static/js/job_applications_filters.js    |  1 -
 itou/templates/apply/list_for_job_seeker.html |  4 ----
 itou/templates/apply/list_for_prescriber.html |  4 ----
 itou/templates/apply/list_for_siae.html       |  4 ----
 itou/templates/approvals/list.html            |  3 ---
 tests/www/apply/__snapshots__/test_list.ambr  | 12 ------------
 7 files changed, 29 deletions(-)
 delete mode 100644 itou/static/js/job_applications_filters.js

diff --git a/itou/static/js/approvals_filters.js b/itou/static/js/approvals_filters.js
index 97aac51ec9..0c220c4d5a 100644
--- a/itou/static/js/approvals_filters.js
+++ b/itou/static/js/approvals_filters.js
@@ -2,4 +2,3 @@ function submitFiltersForm() {
   $("#js-job-applications-filters-form").submit();
 }
 $("#js-job-applications-filters-form :input").change(submitFiltersForm);
-$("#js-job-applications-filters-apply-button").hide();
diff --git a/itou/static/js/job_applications_filters.js b/itou/static/js/job_applications_filters.js
deleted file mode 100644
index ce0b787a84..0000000000
--- a/itou/static/js/job_applications_filters.js
+++ /dev/null
@@ -1 +0,0 @@
-$("#js-job-applications-filters-apply-button").hide();
diff --git a/itou/templates/apply/list_for_job_seeker.html b/itou/templates/apply/list_for_job_seeker.html
index 32bb9fba95..73364aa6f0 100644
--- a/itou/templates/apply/list_for_job_seeker.html
+++ b/itou/templates/apply/list_for_job_seeker.html
@@ -27,9 +27,6 @@
                                     {% include "apply/includes/job_applications_filters/statut.html" %}
                                     <hr>
                                     {% include "apply/includes/job_applications_filters/dates.html" %}
-                                    <button id="js-job-applications-filters-apply-button" class="btn btn-block btn-primary mt-3" aria-label="Appliquer les filtres">
-                                        Appliquer
-                                    </button>
                                 </div>
                             </form>
                         </div>
@@ -44,5 +41,4 @@
 {% block script %}
     {{ block.super }}
     <script src='{% static "js/htmx_compat.js" %}'></script>
-    <script src='{% static "js/job_applications_filters.js" %}'></script>
 {% endblock %}
diff --git a/itou/templates/apply/list_for_prescriber.html b/itou/templates/apply/list_for_prescriber.html
index fc1390c5e2..7f06deb78c 100644
--- a/itou/templates/apply/list_for_prescriber.html
+++ b/itou/templates/apply/list_for_prescriber.html
@@ -36,9 +36,6 @@
                                     {% include "apply/includes/job_applications_filters/eligibility_validated.html" %}
                                     {% include "apply/includes/job_applications_filters/criteria.html" %}
                                     {% include "apply/includes/job_applications_filters/departments.html" %}
-                                    <button id="js-job-applications-filters-apply-button" class="btn btn-block btn-primary mt-3" aria-label="Appliquer les filtres">
-                                        Appliquer
-                                    </button>
                                 </div>
                             </form>
                         </div>
@@ -56,6 +53,5 @@
     {{ block.super }}
     <!-- Needed to use Select2MultipleWidget. -->
     {{ filters_form.media.js }}
-    <script src='{% static "js/job_applications_filters.js" %}'></script>
     <script src='{% static "js/htmx_compat.js" %}'></script>
 {% endblock %}
diff --git a/itou/templates/apply/list_for_siae.html b/itou/templates/apply/list_for_siae.html
index 3ad552aec4..16ec9849ff 100644
--- a/itou/templates/apply/list_for_siae.html
+++ b/itou/templates/apply/list_for_siae.html
@@ -42,9 +42,6 @@ <h2>{{ siae.display_name }}</h2>
                                     {% include "apply/includes/job_applications_filters/dates.html" %}
                                     {% include "apply/includes/job_applications_filters/selected_jobs.html" %}
                                     {% include "apply/includes/job_applications_filters/sender.html" %}
-                                    <button id="js-job-applications-filters-apply-button" class="btn btn-block btn-primary mt-3" aria-label="Appliquer les filtres">
-                                        Appliquer
-                                    </button>
                                 </div>
                             </form>
                         </div>
@@ -63,5 +60,4 @@ <h2>{{ siae.display_name }}</h2>
     <!-- Needed to use Select2MultipleWidget. -->
     {{ filters_form.media.js }}
     <script src='{% static "js/htmx_compat.js" %}'></script>
-    <script src='{% static "js/job_applications_filters.js" %}'></script>
 {% endblock %}
diff --git a/itou/templates/approvals/list.html b/itou/templates/approvals/list.html
index 9eecb6ab58..0dd724a0af 100644
--- a/itou/templates/approvals/list.html
+++ b/itou/templates/approvals/list.html
@@ -28,9 +28,6 @@
                                         <legend>Fin du parcours en IAE</legend>
                                         {% bootstrap_field filters_form.expiry layout="inline" %}
                                     </fieldset>
-                                    <button id="js-job-applications-filters-apply-button" class="btn btn-block btn-primary mt-3" aria-label="Appliquer les filtres">
-                                        Appliquer
-                                    </button>
                                 </div>
                             </form>
                         </div>
diff --git a/tests/www/apply/__snapshots__/test_list.ambr b/tests/www/apply/__snapshots__/test_list.ambr
index e9170e803d..ca7c5d7b52 100644
--- a/tests/www/apply/__snapshots__/test_list.ambr
+++ b/tests/www/apply/__snapshots__/test_list.ambr
@@ -242,9 +242,6 @@
       </fieldset>
   
   
-                                      <button aria-label="Appliquer les filtres" class="btn btn-block btn-primary mt-3" id="js-job-applications-filters-apply-button">
-                                          Appliquer
-                                      </button>
                                   </div>
                               </form>
                           </div>
@@ -433,9 +430,6 @@
   
       </fieldset>
   
-                                      <button aria-label="Appliquer les filtres" class="btn btn-block btn-primary mt-3" id="js-job-applications-filters-apply-button">
-                                          Appliquer
-                                      </button>
                                   </div>
                               </form>
                           </div>
@@ -630,9 +624,6 @@
   
       </fieldset>
   
-                                      <button aria-label="Appliquer les filtres" class="btn btn-block btn-primary mt-3" id="js-job-applications-filters-apply-button">
-                                          Appliquer
-                                      </button>
                                   </div>
                               </form>
                           </div>
@@ -814,9 +805,6 @@
   
       </fieldset>
   
-                                      <button aria-label="Appliquer les filtres" class="btn btn-block btn-primary mt-3" id="js-job-applications-filters-apply-button">
-                                          Appliquer
-                                      </button>
                                   </div>
                               </form>
                           </div>