Fix typo in latest_common_approval

Hopefully, this code is no longer in use and the typo did not affect too
many users. 🙈

itou/users/models.py

@@ -472,7 +472,7 @@ def latest_common_approval(self):
             self.latest_approval
             and self.latest_approval.is_in_waiting_period
             and self.latest_pe_approval
-            and self.latest_pe_approval.is_valid
+            and self.latest_pe_approval.is_valid()
         ):
             return self.latest_pe_approval
 

tests/users/test_models.py

@@ -1122,6 +1122,21 @@ def test_latest_common_approval_when_only_pe_approval(self):
         pe_approval = PoleEmploiApprovalFactory(nir=user.jobseeker_profile.nir)
         assert user.latest_common_approval == pe_approval
 
+    def test_latest_common_approval_with_expired_pe_approval(self):
+        user = JobSeekerFactory()
+        today = timezone.localdate()
+        PoleEmploiApprovalFactory(
+            nir=user.jobseeker_profile.nir,
+            start_at=today - datetime.timedelta(days=30),
+            end_at=today - datetime.timedelta(days=1),
+        )
+        approval = ApprovalFactory(
+            user=user,
+            start_at=today - datetime.timedelta(days=10),
+            end_at=today - datetime.timedelta(days=7),
+        )
+        assert user.latest_common_approval == approval
+
     def test_latest_common_approval_is_approval_if_valid(self):
         user = JobSeekerFactory()
         approval = ApprovalFactory(user=user)