Skip to content

Commit

Permalink
apply: privilégier l’ouverture d’onglet au parcours de candidature
Browse files Browse the repository at this point in the history
fix(_company_info.html): open_in_tab controls link behaviour
  • Loading branch information
calummackervoy committed Aug 6, 2024
1 parent 49582b1 commit f8a7255
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 7 deletions.
2 changes: 1 addition & 1 deletion itou/templates/apply/includes/accept_section.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ <h3 class="modal-title" id="confirmation-modal-label">Confirmation de l’embauc
<p>
Êtes-vous sûr(e) de vouloir confirmer l’embauche de <strong>{{ job_seeker.get_full_name }}</strong> dans la structure suivante ?
</p>
{% include "companies/includes/_company_info.html" with company=siae extra_box_class="mb-3 mb-lg-5" only %}
{% include "companies/includes/_company_info.html" with company=siae extra_box_class="mb-3 mb-lg-5" open_in_tab=True only %}
</div>
<div class="modal-footer">
<button type="button" class="btn btn-sm btn-outline-primary" data-bs-dismiss="modal">Retour</button>
Expand Down
2 changes: 1 addition & 1 deletion itou/templates/apply/includes/job_seeker_info.html
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
<li>
<small>Curriculum vitae</small>
{% if job_application.resume_link %}
<a href="{{ job_application.resume_link }}" class="btn-link btn-ico">
<a href="{{ job_application.resume_link }}" class="btn-link btn-ico" target="_blank" rel="noreferrer noopener">
<span>Télécharger le CV</span>
<i class="ri-download-2-line"></i>
</a>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ <h5 class="modal-title" id="modal_title">Confirmation du transfert</h5>
<p>
Êtes-vous sûr de vouloir transférer la candidature de <b>{{ job_application.job_seeker.get_full_name }}</b> dans la structure suivante ?
</p>
{% include "companies/includes/_company_info.html" with company=siae extra_box_class="mb-3 mb-lg-5" only %}
{% include "companies/includes/_company_info.html" with company=siae extra_box_class="mb-3 mb-lg-5" open_in_tab=True only %}
</div>
<div class="modal-footer">
<button type="button" class="btn btn-sm btn-outline-secondary" data-bs-dismiss="modal">Retour</button>
Expand Down
2 changes: 1 addition & 1 deletion itou/templates/apply/process_internal_transfer.html
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ <h1>Confirmation du transfert</h1>
Êtes-vous sûr de vouloir transférer la candidature de <b>{{ job_app_to_transfer.job_seeker.get_full_name }}</b> dans la structure suivante ?
</p>
{% endif %}
{% include "companies/includes/_company_info.html" with company=company extra_box_class="mb-3 mb-lg-5" only %}
{% include "companies/includes/_company_info.html" with company=company extra_box_class="mb-3 mb-lg-5" open_in_tab=True only %}
</div>

{% if job_app_to_transfer.to_company == company %}
Expand Down
2 changes: 1 addition & 1 deletion itou/templates/apply/submit/application/base.html
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ <h1 class="flex-grow-1">{% include 'apply/includes/_submit_title.html' %}</h1>
<div class="col-12{% if not full_content_width %} col-lg-8{% endif %}">
<div class="c-form">
<div class="col-12 p-0 {% if full_content_width %}col-lg-8 pe-lg-4{% endif %}">
{% include "companies/includes/_company_info.html" with company=siae extra_box_class="mb-3 mb-lg-5" only %}
{% include "companies/includes/_company_info.html" with company=siae extra_box_class="mb-3 mb-lg-5" open_in_tab=True only %}
</div>
<div class="col-12 p-0 {% if full_content_width %}col-lg-8 pe-lg-4{% endif %}">
{% block pre_step_title %}{% endblock %}
Expand Down
2 changes: 1 addition & 1 deletion itou/templates/companies/edit_siae_preview.html
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ <h1>
</h1>
</div>

{% include "companies/includes/_company_info.html" with company=siae extra_box_class="mb-3 mb-lg-5" only %}
{% include "companies/includes/_company_info.html" with company=siae extra_box_class="mb-3 mb-lg-5" open_in_tab=True only %}

<form method="post" class="js-prevent-multiple-submit">
{% csrf_token %}
Expand Down
4 changes: 3 additions & 1 deletion itou/templates/companies/includes/_company_info.html
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ <h3>{{ company.display_name }}</h3>
<a href="{% url 'apply:job_application_external_transfer_step_1_company_card' job_application_id=job_app_to_transfer company_pk=company.pk %}{% if back_url|default:"" %}?back_url={{ back_url|urlencode }}{% endif %}"
class="btn btn-secondary btn-block mt-4">Voir la fiche de l'entreprise</a>
{% else %}
<a href="{% url 'companies_views:card' siae_id=company.pk %}{% if back_url|default:"" %}?back_url={{ back_url|urlencode }}{% endif %}" class="btn btn-secondary btn-block mt-4">Voir la fiche de l'entreprise</a>
<a href="{% url 'companies_views:card' siae_id=company.pk %}{% if back_url|default:"" and not open_in_tab|default:False %}?back_url={{ back_url|urlencode }}{% endif %}"
class="btn btn-secondary btn-block mt-4"
{% if open_in_tab|default:False %}target="_blank"{% endif %}>Voir la fiche de l'entreprise</a>
{% endif %}
</div>
</div>

0 comments on commit f8a7255

Please sign in to comment.