UX/UI : Limiter la sélection rapide à un candidat dans la liste des fiches salarié [GEN-1687] #4344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonial
approved these changes
Jul 2, 2024
xavfernandez
reviewed
Jul 2, 2024
| @@ -80,10 +80,11 @@ class SelectEmployeeRecordStatusForm(forms.Form): | |||
|
|
|||
|
|
|||
| class EmployeeRecordFilterForm(forms.Form): | |||
| job_seekers = forms.MultipleChoiceField( | |||
| job_seeker = forms.TypedChoiceField( | |||
There was a problem hiding this comment.
Pourquoi le TypedChoiceField ?
There was a problem hiding this comment.
Parce qu’on compare à job_application.job_seeker_id qui est un entier (car les candidatures ont déjà été chargées en mémoire, je n’ai pas cherché pourquoi de peur de ce que je trouverais).
There was a problem hiding this comment.
Ah, c’est pour compter le nombre d’objets dans chaque catégorie pour les badges. 🙈
There was a problem hiding this comment.
Merci pour la vérif :)
| @@ -211,9 +211,9 @@ def list_employee_records(request, template_name="employee_record/list.html"): | |||
| if status == Status.NEW: | |||
| # Browse to get only the linked employee record in "new" state | |||
| data = eligible_job_applications | |||
| if job_seekers := filters_form.cleaned_data.get("job_seekers"): | |||
| if job_seeker := filters_form.cleaned_data.get("job_seeker"): | |||
There was a problem hiding this comment.
Suggested change
| if job_seeker := filters_form.cleaned_data.get("job_seeker"): | |
| if job_seeker_id := filters_form.cleaned_data.get("job_seeker"): |
francoisfreitag
force-pushed
the
ff/select-fs
branch
from
9083b1d to
fe63256
Compare
xavfernandez
approved these changes
Jul 2, 2024
| @@ -238,8 +238,8 @@ def list_employee_records(request, template_name="employee_record/list.html"): | |||
| .filter(status=status) | |||
| .order_by(*employee_record_order_by) | |||
| ) | |||
| if job_seekers := filters_form.cleaned_data.get("job_seekers"): | |||
| data = data.filter(job_application__job_seeker__in=job_seekers) | |||
| if job_seeker := filters_form.cleaned_data.get("job_seeker"): | |||
There was a problem hiding this comment.
Suggested change
| if job_seeker := filters_form.cleaned_data.get("job_seeker"): | |
| if job_seeker_id := filters_form.cleaned_data.get("job_seeker"): |
ici aussi du coup :)
There was a problem hiding this comment.
Erf, oui. Merci !
| @@ -80,10 +80,11 @@ class SelectEmployeeRecordStatusForm(forms.Form): | |||
|
|
|||
|
|
|||
| class EmployeeRecordFilterForm(forms.Form): | |||
| job_seekers = forms.MultipleChoiceField( | |||
| job_seeker = forms.TypedChoiceField( | |||
There was a problem hiding this comment.
Merci pour la vérif :)
The select multiple widget is partially broken with the itou-theme. In most places, users actually just want to quickly navigate to a single entry in the list. Simplify the UI and remove bugs by using a TypedChoiceField instead of a MultipleChoiceField.
francoisfreitag
force-pushed
the
ff/select-fs
branch
from
fe63256 to
c2e49c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Le thème casse partiellement le MultipleChoiceField, utilisons plutôt le composant de sélection d’un seul élément.
Dans tous les cas, les utilisateurs utilisent le widget pour accéder rapidement à un candidat, et non pour limiter les éléments présents dans la liste à un ensemble de candidats.
🏝️ Comment tester
💻 Captures d'écran