Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPS : pagination et filtre par nom de bénéficiaire #4361

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

celine-m-s
Copy link
Collaborator

@celine-m-s celine-m-s commented Jul 3, 2024

🤔 Pourquoi ?

Les utilisateurs peinent à retrouver des bénéficiaires.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?

🏝️ Comment tester

Connectez-vous en tant qu'employeur ou prescripteur habilité puis suivez au moins 11 personnes dans GPS. Vérifiez que la pagination est correcte.
Le filtre par nom devrait vous permettre de retrouver un bénéficiaire.

💻 Captures d'écran

image

image

@celine-m-s celine-m-s added the ajouté Ajouté dans le changelog. label Jul 3, 2024
@celine-m-s celine-m-s self-assigned this Jul 3, 2024
@celine-m-s celine-m-s force-pushed the celinems/gps-filters branch 2 times, most recently from d0eeeaf to 38ec362 Compare July 5, 2024 15:03
@celine-m-s celine-m-s added the 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC label Jul 5, 2024
Copy link

github-actions bot commented Jul 5, 2024

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

@celine-m-s celine-m-s added 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC and removed 1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC labels Jul 5, 2024
Copy link

github-actions bot commented Jul 5, 2024

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

itou/templates/gps/my_groups.html Outdated Show resolved Hide resolved
@celine-m-s celine-m-s force-pushed the celinems/gps-filters branch 3 times, most recently from 67cde5e to 24bfe39 Compare July 8, 2024 13:16
@celine-m-s celine-m-s marked this pull request as ready for review July 8, 2024 13:16
@celine-m-s celine-m-s force-pushed the celinems/gps-filters branch from 24bfe39 to 15c2b05 Compare July 8, 2024 13:20
@celine-m-s celine-m-s enabled auto-merge July 8, 2024 13:23
</div>
<div class="d-flex justify-content-between">

{% with membership.follow_up_group.beneficiary.public_id as public_id %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je vois beaucoup de public_id=membership.follow_up_group.beneficiary.public_id au sein de ce bloc with :suspect:

@celine-m-s celine-m-s added this pull request to the merge queue Jul 8, 2024
Merged via the queue into master with commit ee67206 Jul 8, 2024
11 checks passed
@celine-m-s celine-m-s deleted the celinems/gps-filters branch July 8, 2024 13:36
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-recette-jetable [Payé à l’heure] Crée une recette jetable sur CC ajouté Ajouté dans le changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants