PASS IAE: Affichage de l'estimation de durée restante [GEN-228] #4434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonial
force-pushed
the
alaurent/approval_remainder
branch
from
e4e538d to
8433b9c
Compare
tonial
force-pushed
the
alaurent/approval_remainder
branch
from
8433b9c to
d7aa909
Compare
rsebille
reviewed
Jul 17, 2024
Comment on lines
+138
to
+159
| def _get_human_readable_estimate(self, days): | ||
| split = [] | ||
| years = days // 365 | ||
| if years: | ||
| split.append(f"{years} an{pluralizefr(years)}") | ||
| days = days % 365 | ||
| months = days // 30 | ||
| if months: | ||
| split.append(f"{months} mois") | ||
| if years: | ||
| return "Environ " + " et ".join(split) | ||
| days = days % 30 | ||
| weeks = days // 7 | ||
| if weeks: | ||
| split.append(f"{weeks} semaine{pluralizefr(weeks)}") | ||
| if months: | ||
| return "Environ " + " et ".join(split) | ||
| days = days % 7 | ||
| if days: | ||
| split.append(f"{days} jour{pluralizefr(days)}") | ||
| return " et ".join(split) | ||
|
|
There was a problem hiding this comment.
Ça m'a fait penser au filtre Django timeuntil mais je pense qu'utiliser la fonction sous-jacente est encore mieux : https://github.com/django/django/blob/5dc17177c38662d6f4408258ee117cd80e0cb933/django/utils/timesince.py#L138-L142
There was a problem hiding this comment.
Trop bien, je vais essayer de l'utiliser à la place.
J'ai juste un doute sur le "Environ" à mettre devant 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
C'est plus facile à comprendre que "571 jours"
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran