Profil salarié: bascule vers une nouvelle URL & utilisation de l'identifiant publique du salarié dans l'URL #4713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it actually contains information about an employee and its title is "Salarié" not "PASS IAE"
xavfernandez
added
the
no-changelog
francoisfreitag
approved these changes
Sep 10, 2024
xavfernandez
added
the
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
On aura bientôt une vrai page de détail de PASS IAE et la page salarié actuelle avec son URL en
/approvals/detail/{PK de PASS}n'est pas cette page.Elle est maintenant située en
/employees/detail/{public_id de salarié}.J'ai préféré laisser la vue liste en l'état pour ne pas tout déplacer d'un coup mais en cible il faudrait également adapter
ApprovalListView.🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran