Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech : Chainer les appels pour .raise_for_status() d'HTTPX #5313

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

rsebille
Copy link
Contributor

🤔 Pourquoi ?

Il s'avère que .raise_for_status() retourne la réponse ! Donc pas besoin de saucissonner les appels.
Documentation associée : https://www.python-httpx.org/quickstart/#response-status-codes

🏝️ Comment tester

Dépend si vous faite confiance ou pas à notre suite de test 🤷 🙈 😇

@rsebille rsebille added the no-changelog Ne doit pas figurer dans le journal des changements. label Dec 26, 2024
@rsebille rsebille self-assigned this Dec 26, 2024
@rsebille rsebille changed the title Tech : Utilisation de la forme _inline_ pour .raise_for_status() d'HTTPX Tech : Chainer les appels pour .raise_for_status() d'HTTPX Dec 26, 2024
Copy link
Contributor

@tonial tonial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@rsebille rsebille added this pull request to the merge queue Jan 6, 2025
Merged via the queue into master with commit a7d824b Jan 6, 2025
10 checks passed
@rsebille rsebille deleted the rsebille/inline-raise-for-status branch January 6, 2025 09:59
Copy link

sentry-io bot commented Jan 6, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Ne doit pas figurer dans le journal des changements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants