GPS: Transformer la liste des bénéficiaires en tableau #5359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonial
added
the
1-recette-jetable
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
hellodeloo
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
@tonial J'ai pushé un petit commit de correctifs UI et now c'est ok pour moi 👍
(je te laisse rebase mon commit après avoir jeté un œil aux modifs)
tonial
force-pushed
the
alaurent/gps_list
branch
from
33bbb32 to
d01d08a
Compare
|
merci ! |
xavfernandez
reviewed
Jan 9, 2025
| @@ -30,14 +30,20 @@ def my_groups(request, template_name="gps/my_groups.html"): | |||
| .annotate(nb_members=Count("follow_up_group__members")) | |||
| .order_by("-created_at") | |||
| .select_related("follow_up_group", "follow_up_group__beneficiary", "member") | |||
| .prefetch_related("follow_up_group__members") | |||
| .prefetch_related( | |||
There was a problem hiding this comment.
Je me dis qu'un assertSnapshotQueries sur la vue pourrait être bien du coup :)
tonial
force-pushed
the
alaurent/gps_list
branch
from
19b5323 to
a5f0437
Compare
tonial
force-pushed
the
alaurent/gps_list
branch
from
a5f0437 to
6ab3e8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
https://www.notion.so/gip-inclusion/Transformer-la-liste-des-b-n-ficiaires-en-tableau-14d5f321b604807db116cdd0197dc5ec?pvs=4
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran