Le badge 20+ candidatures sur les résultats de recherche ne doit pas inclure de candidatures archivées #5378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dejafait
force-pushed
the
dejafait/fix_annotation_is_popular
branch
from
ead2a31 to
5538caa
Compare
dejafait
changed the title
tonial
reviewed
Jan 14, 2025
| @@ -17,7 +17,7 @@ | |||
| <label class="fw-bold stretched-link order-2 order-md-1 m-0" for="{{ choice.id_for_label }}"> | |||
| {{ choice.choice_label }} | |||
| </label> | |||
| {% if job_description.is_popular %} | |||
| {% if job_description.is_overwhelmed %} | |||
| <div class="order-1 order-md-2"> | |||
| <span class="badge badge-sm rounded-pill bg-accent-03 text-primary ms-0 ms-lg-2 mt-1 mt-lg-0"><i class="ri-group-line"></i>20+ candidatures</span> | |||
There was a problem hiding this comment.
Tu pourrais ici aussi utiliser job_description.OVERWHELMED_THRESHOLD au lieu de 20 (comme dans _card_jobdescription.html)
|
|
||
| # Test overwhelmed threshold: overwhelmed job description | ||
| overwhelmed_job_description = siae_job_descriptions[0] | ||
| for _ in range(JobDescription.OVERWHELMED_THRESHOLD + 1): |
There was a problem hiding this comment.
Tu pourrais en profiter pour le remplacer par JobApplicationFactory.create_batch(JobDescription.OVERWHELMED_THRESHOLD + 1, to_company=company, selected_jobs=[overwhelmed_job_description], job_seeker=job_seeker)
| overwhelmed_job_description = siae_job_descriptions[0] | ||
| for _ in range(JobDescription.OVERWHELMED_THRESHOLD + 1): | ||
| JobApplicationFactory( | ||
| to_company=company, selected_jobs=[overwhelmed_job_description], job_seeker=job_seeker |
There was a problem hiding this comment.
Il faudrait aussi vérifier que les candidatures archivées ne comptent pas, peut être en archivant une des candidatures créées ici ?
|
C'est beaucoup plus logique avec ton renommage :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.notion.so/plateforme-inclusion/Le-badge-20-candidature-sur-les-r-sultats-de-recherche-ne-doit-pas-inclure-de-candidatures-archiv-e-177e8fa5c35b80e49344f093e58cf484
🤔 Pourquoi ?
Les candidatures archivées (trop anciennes) ne doivent pas être comptées pour l’affichage du badge 20+ candidatures car :
🌈 Et un petit bonus technique en passant
popularenoverwhelmedqui est plus pertinent car l'état en question est en fait indésirable.