Candidature: Corriger le bouton "Retour" de la modale d'acceptation de candidature [GEN-2376] #5390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| hx-swap="outerHTML" | ||
| hx-vals='{"confirmed": "True"}' | ||
| hx-include="#acceptForm" | ||
| {% matomo_event "candidature" "submit" "accept_application_confirmation" %}> |
There was a problem hiding this comment.
En alternative, tu pourrais ajouter un hx-trigger pour filtrer les évènements qui déclenche l'appel ajax.
There was a problem hiding this comment.
Je trouve ça pas plus simple à relire/comprendre, mais c'est très certainement subjectif 😅
tonial
changed the title
tonial
force-pushed
the
alaurent/boost
branch
from
c7c3b32 to
c258aa8
Compare
We don't want to post to request.path when cancelling the modal
tonial
force-pushed
the
alaurent/boost
branch
from
c258aa8 to
33ea80d
Compare
|
C'est corrigé et testé avec le super |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Bon, par contre, pour le tester, je me demande si je parse le html pour m'assurer que les éléments parents du bouton n'ont pas d'attribut hx-post, ou si je mets juste une snapshot (qui ne vérifie pas grand chose mais aura au moins le mérite de nous faire remarquer qu'un truc change.
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran