API: commentaire temporaire des scopes de l'API Rome en maintenance #5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavfernandez
added
the
no-changelog
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Those two scopes makes the _refresh_token call fail with an `invalid_scope` error (possibly related to a maintenance on Rome API). This error currently prevents all use of France Travail APIs while those 2 scopes are only needed for the `sync_romes_and_appellations` command. This commenting should allow the use of the other API but we'll need to uncomment them at one point to reenable `sync_romes_and_appellations`.
xavfernandez
force-pushed
the
xfernandez/comment_currently_invalid_scopes
branch
from
a1d9b99 to
7331fd2
Compare
celine-m-s
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Ces 2 scopes font que toutes les demandes de token échouent avec comme erreur
invalid_scope.Cela empêche toutes les utilisations des APIs FranceTravail.
Cette PR débloque la situation mais idéalement je pense qu'il faudrait que chaque commande ne demande que les scopes dont elle a besoin.
Je n'ai pas commenté la commande
sync_romes_and_appellations: son échec dans Sentry nous rappellera peut-être d'aller dé-commenter ces scopes si on ne l'a pas encore fait.🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran