Skip to content

Commit

Permalink
Reduce the default max texture size for frame quads.
Browse files Browse the repository at this point in the history
For images with lots of frames, a large value preserves quick
resolution, but browsers are glacial at decoding large images.  This
attempts to adjust the balance.
  • Loading branch information
manthey committed Jun 19, 2023
1 parent 4a9cda5 commit 456f758
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@

### Changes
- Change how extensions and fallback priorities in Girder interact ([#1208](../../pull/1208))
- Reduce the default max texture size for frame quads ([#1212](../../pull/1212))

### Bug Fixes
- Fix clearing the style threshold cache ([#1210](../../pull/1210))
-
-
## 1.22.4

### Bug Fixes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ function setFrameQuad(tileinfo, layer, options) {
try {
maxTextureSize = layer.renderer()._maxTextureSize || layer.renderer().constructor._maxTextureSize;
} catch (err) { }
options = Object.assign({}, {maxTextureSize: Math.min(16384, maxTextureSize)}, options);
options = Object.assign({}, {maxTextureSize: Math.min(8192, maxTextureSize || 8192)}, options);
const status = {
tileinfo: tileinfo,
options: options,
Expand Down
2 changes: 1 addition & 1 deletion large_image/tilesource/utilities.py
Original file line number Diff line number Diff line change
Expand Up @@ -864,7 +864,7 @@ def getTileFramesQuadInfo(metadata, options=None):
'frameGroup': 1,
'frameGroupFactor': 4,
'frameGroupStride': 1,
'maxTextureSize': 16384,
'maxTextureSize': 8192,
'maxTextures': 1,
'maxTotalTexturePixels': 1024 * 1024 * 1024,
'alignment': 16,
Expand Down

0 comments on commit 456f758

Please sign in to comment.