Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more DICOMweb transfer syntaxes #1308

Closed
psavery opened this issue Sep 20, 2023 · 5 comments · Fixed by #1393
Closed

Add support for more DICOMweb transfer syntaxes #1308

psavery opened this issue Sep 20, 2023 · 5 comments · Fixed by #1393

Comments

@psavery
Copy link
Collaborator

psavery commented Sep 20, 2023

See discussion here.

This may require making changes to wsidicom.

@psavery
Copy link
Collaborator Author

psavery commented Nov 8, 2023

If this issue is fixed, it will largely fix this issue as well.

@psavery
Copy link
Collaborator Author

psavery commented Nov 30, 2023

If we add the optional dependencies imagecodecs and pylibjpeg-rle, several more transfer syntaxes will be supported. The full list can be found here.

@manthey
Copy link
Member

manthey commented Dec 1, 2023

We can add imagecodecs as a dependency directly, since it has good cross-platform support.

For pylibjpeg-rle, it doesn't have binary wheels for python >= 3.11, which means that we can't install it on modern python without a rust compiler. We can either add this with a version restriction (< 3.11, which means we'll need to update it when they release a newer wheel), or we add it as an extra requires and build our own linux wheels for it. For the nonce, maybe just add it with a version restriction?

@psavery
Copy link
Collaborator Author

psavery commented Dec 1, 2023

Pydicom's RLE decoder only requires numpy to be present. I asked Erik if he would consider using that instead.

@manthey
Copy link
Member

manthey commented Dec 1, 2023

Pydicom's RLE decoder only requires numpy to be present. I asked Erik if he would consider using that instead.

I would have expected RLE to be distinct from jpeg-rle (but I don't know).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants