Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The exception raised by jp2 files from the nd2 reader changed #1242

Merged
merged 1 commit into from
Jul 24, 2023
Merged

The exception raised by jp2 files from the nd2 reader changed #1242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
- More consistency in how local and remote image conversions are performed in Girder ([#1238](../../pull/1238))
- Support showing data from subkeys in annotation lists ([#1241](../../pull/1241))

### Bug Fixes
- The nd2 reader throws a different exception with JP2 files ([#1242](../../pull/1242))

## 1.23.1

### Improvements
Expand Down
2 changes: 1 addition & 1 deletion sources/nd2/large_image_source_nd2/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def __init__(self, path, **kwargs):
# We use dask to allow lazy reading of large images
try:
self._nd2array = self._nd2.to_dask(copy=False, wrapper=False)
except TypeError as exc:
except (TypeError, ValueError) as exc:
self.logger.debug('Failed to read nd2 file: %s', exc)
raise TileSourceError('File cannot be opened via the nd2 source.')
arrayOrder = list(self._nd2.sizes)
Expand Down