Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frame selection bugs #1256

Merged
merged 10 commits into from
Aug 10, 2023
Merged

Fix frame selection bugs #1256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b0a00b1
Fix applying min and max from preset
annehaley Aug 9, 2023
97468d8
Fix preset to current style comparison
annehaley Aug 9, 2023
655fb50
Protect agaisnt negative exclusion box width error
annehaley Aug 9, 2023
4265aaa
Fix updating histogram handles
annehaley Aug 9, 2023
6e8716d
Add vue linting
manthey Aug 9, 2023
85acae7
Merge remote-tracking branch 'origin/lint-vue-modules' into frame-sel…
annehaley Aug 9, 2023
9bf3a39
Fix formatting
annehaley Aug 9, 2023
2895090
Ignore warning for nextTick not found
annehaley Aug 9, 2023
0f47b3d
Remove package-lock.json
annehaley Aug 9, 2023
1617726
Use nextTick from Vue
annehaley Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions girder/girder_large_image/web_client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,18 @@
"webpack": "webpack.helper"
},
"eslintConfig": {
"extends": "@girder",
"extends": [
"@girder",
"plugin:vue/recommended"
],
"overrides": [
{
"files": [
"*.js",
"*.vue"
]
}
],
"rules": {
"for-direction": "error",
"getter-return": "error",
Expand All @@ -54,7 +65,8 @@
"import/exports-last": "error",
"promise/no-native": "error",
"promise/no-return-in-finally": "error",
"promise/no-return-wrap": "error"
"promise/no-return-wrap": "error",
"vue/require-prop-types": "off"
},
"root": true
},
Expand All @@ -75,20 +87,21 @@
"stylusSupremacy.alwaysUseZeroWithoutUnit": true,
"stylusSupremacy.reduceMarginAndPaddingValues": true,
"devDependencies": {
"@girder/eslint-config": "^3.0.0-rc1",
"@girder/eslint-config": "*",
"@girder/pug-lint-config": "*",
"eslint": "^8.20.0",
"eslint-config-semistandard": "^17.0.0",
"eslint-config-standard": "^17.0.0",
"eslint-plugin-backbone": "^2.1.1",
"eslint-plugin-import": "^2.25.3",
"eslint-plugin-n": "^15.2.4",
"eslint-plugin-promise": "^6.0.0",
"@girder/pug-lint-config": "^3.0.0-rc1",
"eslint-plugin-vue": "~9.14.0",
"pug-lint": "^2.6.0",
"stylus-supremacy": "^2.17.5"
},
"scripts": {
"lint": "eslint --cache . && eslint --no-eslintrc -c ./package.json --cache ../../test_girder/web_client_specs && pug-lint . && stylus-supremacy format --compare ./**/*.styl --options package.json",
"format": "eslint --cache --fix . && eslint --no-eslintrc -c ./package.json --cache --fix ../../test_girder/web_client_specs && eslint --cache --fix . && stylus-supremacy format ./**/*.styl --replace --options package.json"
"format": "eslint --cache --fix . && eslint --no-eslintrc -c ./package.json --cache --fix ../../test_girder/web_client_specs && stylus-supremacy format ./**/*.styl --replace --options package.json"
}
}
Loading