Abstract caching and support entrypoints #876
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstracts the caching mechanism so that external projects can implement a cache interface and use entrypoints to make it available to large_image.
Generally, this is working for django-large-image with girder/django-large-image#32
Todo:
MemCache
cache be chosen appropriately? Is it ignored when not available and is it chosen overpython
when available?loadCaches()
only be called once rather than on everyCacheFactory.getCache()
call?CacheFactory.getCacheSize()
andpickAvailableCache()
and how are they affected by these changes?BaseCache.getCache()
returns aNone
cache lock? can/should we support that?django-large-image