Set up Liam ERD on GitHub Pages #1
Conversation
FunamaYukina
force-pushed
the
gh-pages
branch
from
8d28057 to
9e4ddb8
Compare
FunamaYukina
temporarily deployed
to
github-pages
GitHub Actions
Inactive
FunamaYukina
force-pushed
the
gh-pages
branch
from
9e4ddb8 to
c14e7f6
Compare
FunamaYukina
temporarily deployed
to
github-pages
GitHub Actions
Inactive
.github/workflows/github-pages.yml
Outdated
| - main | ||
| paths: | ||
| - .github/workflows/github-pages.yml | ||
| - migrations/**/*.sql |
There was a problem hiding this comment.
This line is not necessary because this file is not in giselles-ai/erd due to repository split.
| - migrations/**/*.sql |
There was a problem hiding this comment.
I see.Thank you for teaching me🙏.
I've removed it. c98687f
| - name: Prepare the input file (dump.sql) | ||
| shell: bash | ||
| run: | | ||
| pg_dump_docker_image="postgres:16.6-bookworm" # ubuntu-latest pg_dump command is a bit old. |
There was a problem hiding this comment.
nits: The version of postgres in line 34 is 15, so it should match either.
There was a problem hiding this comment.
Oh, sorry.
I've corrected it.(use postgres:16.6-bookworm ) c98687f
FunamaYukina
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
@hoshinotsuyoshi |
.github/workflows/github-pages.yml
Outdated
| - .github/workflows/github-pages.yml | ||
| workflow_dispatch: | ||
| schedule: | ||
| # Schedule: Runs at 9:00 AM JST every day. |
There was a problem hiding this comment.
nits: It's unclear how frequently this schedule will be viewed by Japanese users, so feel free to remove this note.
There was a problem hiding this comment.
Oh, you are right🙏.
I've deleted the note. 28c5373
.github/workflows/github-pages.yml
Outdated
|
|
||
| jobs: | ||
| # NOTE: Following the example below, the job is structured into distinct build and deploy phases. | ||
| # see https://docs.github.com/ja/pages/getting-started-with-github-pages/using-custom-workflows-with-github-pages |
There was a problem hiding this comment.
nits: An en version might be suitable too.
There was a problem hiding this comment.
It is also good to let the browser settings determine the language. 😄
https://docs.github.com/pages/getting-started-with-github-pages/using-custom-workflows-with-github-pages
There was a problem hiding this comment.
That's correct as well.👍 Thank you!
28c5373
| workflow_dispatch: | ||
| schedule: | ||
| # Schedule: Runs at 9:00 AM JST every day. | ||
| - cron: "0 0 * * *" |
There was a problem hiding this comment.
FYI:
This is not relevant for this repository, but public repositories have this limitation.
In a public repository, scheduled workflows are automatically disabled when no repository activity has occurred in 60 days. For information on re-enabling a disabled workflow, see Disabling and enabling a workflow.
There was a problem hiding this comment.
Thank you for the information! I didn't know that. 👀
FunamaYukina
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Thank you all for reviewing.✨ |
Summary
I've set up a GitHub Actions workflow and configured the Pages and Environments settings.
Setting
https://github.com/giselles-ai/erd/settings/pages
https://github.com/giselles-ai/erd/settings/environments
GitHub Page
https://giselles-ai.github.io/erd/
Related Issue
Changes
Testing
Action Log
https://github.com/giselles-ai/erd/actions/runs/12492944120/job/34860817326
Other Information
I'm still learning GitHub Actions, so a detailed review would be very helpful🙏.