curl: fix --write-out '%{http_code}' with Secure Channel
#122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `git update-git-for-windows` command is a Unix Shell script that
relies heavily on `curl`; For example, it calls:
curl --silent --show-error --output /tmp/gfw-httpget-ruMLqjGG.txt \
--write-out '%{http_code}' \
https://api.github.com/repos/git-for-windows/git/releases/latest
This worked well until cURL v8.8.0 was integrated. With the Secure
Channel backend, the invocation would fail with this error message:
curl: (43) A libcurl function was given a bad argument
The same issue had been reported for a different SSL backend:
curl/curl#13845. Conveniently, all we have to
do is to Backport the fix from the PR that addressed that ticket to
address the bug at hand.
This fixes microsoft/git#655.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
mingw-w64-curl-8.8.0
branch
from
25421bd
to
3a4474a
Compare
|
/deploy |
|
/deploy mingw-w64-curl The i686/x86_64 and the arm64 workflow runs were started. |
derrickstolee
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Thank you for the fix, @dscho. What's the plan for getting back onto mainline curl after your patch is accepted by curl?
The patch was backported from cURL, it'll be in their next version, so it's a smooth path back to mainline ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
git update-git-for-windowscommand is a Unix Shell script that relies heavily oncurl; For example, it calls:curl --silent --show-error --output /tmp/gfw-httpget-ruMLqjGG.txt
--write-out '%{http_code}'
https://api.github.com/repos/git-for-windows/git/releases/latest
This worked well until cURL v8.8.0 was integrated. With the Secure Channel backend, the invocation would fail with this error message:
curl: (43) A libcurl function was given a bad argument
The same issue had been reported for a different SSL backend: curl/curl#13845. Conveniently, all we have to do is to Backport the fix from the PR that addressed that ticket to address the bug at hand.
This fixes microsoft/git#655.