Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl: update to 5.38.0 #115

Closed
wants to merge 9 commits into from
Closed

perl: update to 5.38.0 #115

wants to merge 9 commits into from

Conversation

gitforwindowshelper[bot]
Copy link

@dscho
Copy link
Member

dscho commented Jul 3, 2023

I guess this PR gives a good reason to switch git-for-windows-automation and gfw-helper-github-app to make the package name a part of the deploy check run name: We will need to rebuild quite a few packages that depend on Perl (and encode the major version number in the DLL name, therefore would not work anymore after the upgrade).

Last time we had a major Perl version upgrade was in #57, and I seem to have failed to record which dependencees needed to be rebuilt. But there is git-for-windows/git-sdk-64@1fb28b3 which lists these:

  • perl-Clone
  • perl-HTML-Parser
  • perl-Locale-Gettext
  • perl-Net-SSLeay
  • perl-TermReadKey
  • perl-XML-Parser
  • perl-YAML-Syck
  • subversion

So we'll also need to increment the respective pkgrel values of those.

@rimrul rimrul marked this pull request as ready for review July 29, 2023 07:34
dscho and others added 2 commits August 6, 2023 21:02
Co-authored-by: Matthias Aßhauer <mha1993@live.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Let's use the excuse of having to rebuild the Perl module after
upgrading to a new Perl version anyway.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member

dscho commented Aug 6, 2023

Last time we had a major Perl version upgrade was in #57, and I seem to have failed to record which dependencees needed to be rebuilt. But there is git-for-windows/git-sdk-64@1fb28b3 which lists these:

  • [...]

Ugh. Since msys2/MSYS2-packages@9652bfd, vim.exe also links to the Perl DLL. I have zero interest to (re-)build a custom vim package in Git for Windows (even if I naturally will have to do that for the i686 variant sigh). Therefore, we may want to align with MSYS2's Perl upgrade plans and keep the Perl v5.36->v5.38 upgrade out of the imminent Git for Windows v2.42.0.

Let's use the excuse of having to rebuild the Perl module after
upgrading to a new Perl version anyway.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@lazka
Copy link

lazka commented Sep 17, 2023

Ugh. Since msys2/MSYS2-packages@9652bfd, vim.exe also links to the Perl DLL.

I'm happy to remove the perl dep (somehow?), I just saw it linking in CI and made it explicit. Not a vim user, so not sure what would be lost there.

@dscho
Copy link
Member

dscho commented Sep 18, 2023

Ugh. Since msys2/MSYS2-packages@9652bfd, vim.exe also links to the Perl DLL.

I'm happy to remove the perl dep (somehow?), I just saw it linking in CI and made it explicit.

It was not actually your change that caused the perl DLL to be linked statically into vim.exe @lazka . It was a change introduced in Perl v5.36. Here is my attempt at backporting the workaround that the VIM project adopted.

@dscho dscho mentioned this pull request Nov 25, 2023
@dscho
Copy link
Member

dscho commented Nov 25, 2023

Let's close this in favor of #139.

@dscho dscho closed this Nov 25, 2023
@dscho dscho deleted the perl-5.38.0 branch November 25, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New perl version] v5.38.0
2 participants