Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update screenshots #33

Merged
merged 4 commits into from
Nov 20, 2021
Merged

Update screenshots #33

merged 4 commits into from
Nov 20, 2021

Conversation

dscho
Copy link
Member

@dscho dscho commented Nov 19, 2021

Over in #28, @vtbassmatt pointed out that our screenshots do not have the same dimensions.

While looking into this, I realized that not only is that true, the screenshots are also of an ancient Git for Windows version, predating the v2.x era we're in since August 2015.

So let's update the screenshots. The diff is best viewed using the rich diff:
image

While at it, automate generating the thumbnails.

The screenshots we had still showed msysGit-based Git for Windows, and
the resolution was really low.

We're in the third decade of the twenty-first century, and it is high
time that we had some higher-quality, and more up to date screenshots.

While at it, ensure that the screenshots all have the very same
dimensions, this will make for a much more pleasant viewing experience.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
We are about to add a script to generate thumbnail images, and we will
lean on Jimp to do that for us.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member Author

dscho commented Nov 19, 2021

One thing is a bit unclear to me: whether we want to have those super small thumbnails. I don't know that they make a lot of sense in this time and age of HiRes screens.

Thoughts?

@dscho dscho mentioned this pull request Nov 19, 2021
@prertik
Copy link

prertik commented Nov 19, 2021

Yeah, I also don't think we need to do those super small thumbnails.

@dscho
Copy link
Member Author

dscho commented Nov 19, 2021

Yeah, I also don't think we need to do those super small thumbnails.

Do you know what the current story is on multiple resolutions, with regards to responsive design and mobile devices? I could imagine that we should have thumbnails that are small enough that mobile phones do not have to deplete the battery just to scale down the screenshot. If that hunch is true, I wonder what the recommended size(s) is/are?

@vtbassmatt
Copy link

vtbassmatt commented Nov 19, 2021

My go-to example for doing thumbnails and high-res stuff is Emojipedia. If you pick an emoji and then use web dev tools to "inspect" the PNG-based ones, you get something like:

<img
  src="https://emojipedia-us.s3.dualstack.us-west-1.amazonaws.com/thumbs/120/apple/285/sparkles_2728.png"
  srcset="https://emojipedia-us.s3.dualstack.us-west-1.amazonaws.com/thumbs/240/apple/285/sparkles_2728.png 2x" 
  alt="Sparkles on Apple iOS 14.6"
  width="120" height="120">

I believe this lets high-DPI clients pick a higher-res version while low-DPI clients save a little bandwidth.

@dscho
Copy link
Member Author

dscho commented Nov 19, 2021

srcset

First time I came across that attribute. Here are the docs: https://html.com/attributes/img-srcset/

@dscho dscho merged commit 1c98497 into git-for-windows:main Nov 20, 2021
@dscho dscho deleted the update-screenshots branch November 20, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants