Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search field delete/backspace should not carry through to deleting commits #991

Open
matthewhively opened this issue Apr 16, 2024 · 1 comment
Labels
good first issue A change that shouldn't involve too much insider knowledge

Comments

@matthewhively
Copy link

When I'm typing in the search field, and want to delete everything I've typed there and start a new search, I usually am lazy and press and hold down delete key.
Currently, when the search field runs out of characters it automatically closes and transfers focus back to the main GitUp window. Which, if I'm holding down delete still, will then attempt to delete the HEAD commit of my current branch. Thankfully there is a confirmation box for that, but I would wager the delete commit action is NEVER what any dev would want to happen in that scenario.

Essentially this comes down to a focus issue, the search box probably should not instantly & automatically close thereby transferring active context back to the main window when the user is still using the keyboard.
If the user clicks the X button within the search field that makes sense to completely clear and close out the search sidebar, but not any sort of keyboard entry. My cursor should remain within the search field unless I move out of it (tab key or a click of some kind)

@lucasderraugh
Copy link
Collaborator

I agree. Only the x, clicking elsewhere (changing focus, includes tab), or the escape key should probably get you out of that flow.

@lucasderraugh lucasderraugh added the good first issue A change that shouldn't involve too much insider knowledge label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A change that shouldn't involve too much insider knowledge
Development

No branches or pull requests

2 participants