Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker JRE, base image update #18

Open
srbala opened this issue Jan 29, 2020 · 9 comments
Open

Docker JRE, base image update #18

srbala opened this issue Jan 29, 2020 · 9 comments

Comments

@srbala
Copy link
Contributor

srbala commented Jan 29, 2020

@takezoe Docker seems using older version of JRE build as base image. https://hub.docker.com/layers/gitbucket/gitbucket/4/images/sha256-909664650e090b5a44c9ac9f696e51cde34e7c79f4367402309ec2361ef20e11

Can we update to adoptopenjdk, thinking of https://hub.docker.com/r/adoptopenjdk/openjdk8-openj9, its OSS with backing of IBM.

If the team agrees, I would like to work on a pull request

@srbala srbala changed the title Docker JRE update Docker JRE, base image update Jan 29, 2020
@takezoe
Copy link
Member

takezoe commented Jan 30, 2020

Do you think OpenJ9 is better than HotSpot?

@srbala
Copy link
Contributor Author

srbala commented Jan 30, 2020

OpenJ9 is base line for IBM JDK, derived from Oracle and IBM combo. HotSpot derivation of Oracle only. OpenJ9 is my personal choice, I have been using it more than a year (previously IBM JDK). We could put multiple docker images, OpenJ9, HotSpot, and Alpine (based images for docker smaller size).

@SIkebe
Copy link
Member

SIkebe commented Jan 30, 2020

AdoptOpenJDK9 is not LTS, so it already EOL'ed in March 2018.
https://adoptopenjdk.net/support.html

Also GitBucket is currently tested against JDK8 and 11.
(both are LTS)

@SIkebe
Copy link
Member

SIkebe commented Jan 30, 2020

Ah, I misunderstood..., its OpenJ9 and not OpenJDK9

@srbala
Copy link
Contributor Author

srbala commented Jan 30, 2020

Yes. Still staying with JDK8 of OpenJ9, LTS version

@takezoe
Copy link
Member

takezoe commented Jan 30, 2020

I see. Generally speaking, HotSpot seems to be a better choise since it's used widely. However, providing multiple docker images might be a good idea if it doesn't require extra effort to maintain.

@srbala
Copy link
Contributor Author

srbala commented Feb 1, 2020

Docker Official jdk8 link, 1M+ downloads https://hub.docker.com/_/adoptopenjdk?tab=tags based on ubuntu base image, 205-225MB size. 1M+ downloads.

https://hub.docker.com/search?q=adoptopenjdk%2Fopenjdk8&type=image OpenJ9 jdk8, other system images debian, alpine, centos, and ubi (redhat 8), size 95-170MB. 5M+ downloads.

@takezoe
Copy link
Member

takezoe commented Feb 3, 2020

I meant the popularity of VM itself, not docker images. However, I understood the advantage of OpenJ9 in terms of image size. If we want to provide a smaller image, OpenJ9 looks a good choice.

@aadrian
Copy link
Member

aadrian commented May 5, 2023

@takezoe from the many OpenJDKs, Zulu JDKs are even better. The Docker images for them: https://github.com/zulu-openjdk/zulu-openjdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants