Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Commit

Permalink
Merge pull request #2408 from github/fixes/remove-experimental-PR-fil…
Browse files Browse the repository at this point in the history
…e-margin

Remove the experimental PR file margin
  • Loading branch information
jcansdale authored Mar 17, 2020
2 parents 4479000 + 0db9174 commit ab1e2b1
Show file tree
Hide file tree
Showing 12 changed files with 0 additions and 385 deletions.
6 changes: 0 additions & 6 deletions src/GitHub.Exports/Settings/generated/IPackageSettings.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@
"type": "bool",
"default": 'true'
},
{
"name": "EditorComments",
"type": "bool",
"default": "false"
},
{
"name": "UIState",
"type": "object",
Expand Down Expand Up @@ -40,7 +35,6 @@ public interface IPackageSettings : INotifyPropertyChanged
{
void Save();
bool CollectMetrics { get; set; }
bool EditorComments { get; set; }
UIState UIState { get; set; }
bool HideTeamExplorerWelcomeMessage { get; set; }
bool EnableTraceLogging { get; set; }
Expand Down
10 changes: 0 additions & 10 deletions src/GitHub.InlineReviews/GitHub.InlineReviews.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@
<Compile Include="Commands\NextInlineCommentCommand.cs" />
<Compile Include="GlobalSuppressions.cs" />
<Compile Include="Margins\InlineCommentTextViewOptions.cs" />
<Compile Include="Margins\PullRequestFileMargin.cs" />
<Compile Include="Margins\PullRequestFileMarginProvider.cs" />
<Compile Include="Glyph\GlyphData.cs" />
<Compile Include="Glyph\GlyphMargin.cs" />
<Compile Include="Glyph\GlyphMarginVisualManager.cs" />
Expand Down Expand Up @@ -97,12 +95,8 @@
<Compile Include="Tags\ShowInlineCommentAnnotationGlyph.xaml.cs">
<DependentUpon>ShowInlineCommentAnnotationGlyph.xaml</DependentUpon>
</Compile>
<Compile Include="ViewModels\PullRequestFileMarginViewModel.cs" />
<Compile Include="ViewModels\InlineCommentPeekViewModel.cs" />
<Compile Include="ViewModels\PullRequestStatusViewModel.cs" />
<Compile Include="Views\PullRequestFileMarginView.xaml.cs">
<DependentUpon>PullRequestFileMarginView.xaml</DependentUpon>
</Compile>
<Compile Include="Views\GlyphMarginGrid.xaml.cs">
<DependentUpon>GlyphMarginGrid.xaml</DependentUpon>
</Compile>
Expand Down Expand Up @@ -251,10 +245,6 @@
<Generator>MSBuild:Compile</Generator>
<SubType>Designer</SubType>
</Page>
<Page Include="Views\PullRequestFileMarginView.xaml">
<SubType>Designer</SubType>
<Generator>MSBuild:Compile</Generator>
</Page>
<Page Include="Views\GlyphMarginGrid.xaml">
<SubType>Designer</SubType>
<Generator>MSBuild:Compile</Generator>
Expand Down
122 changes: 0 additions & 122 deletions src/GitHub.InlineReviews/Margins/PullRequestFileMargin.cs

This file was deleted.

86 changes: 0 additions & 86 deletions src/GitHub.InlineReviews/Margins/PullRequestFileMarginProvider.cs

This file was deleted.

This file was deleted.

46 changes: 0 additions & 46 deletions src/GitHub.InlineReviews/Views/PullRequestFileMarginView.xaml

This file was deleted.

13 changes: 0 additions & 13 deletions src/GitHub.InlineReviews/Views/PullRequestFileMarginView.xaml.cs

This file was deleted.

2 changes: 0 additions & 2 deletions src/GitHub.VisualStudio/Settings/OptionsPage.cs
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,12 @@ protected override void OnActivate(CancelEventArgs e)
void LoadSettings()
{
child.CollectMetrics = packageSettings.CollectMetrics;
child.EditorComments = packageSettings.EditorComments;
child.EnableTraceLogging = packageSettings.EnableTraceLogging;
}

void SaveSettings()
{
packageSettings.CollectMetrics = child.CollectMetrics;
packageSettings.EditorComments = child.EditorComments;
packageSettings.EnableTraceLogging = child.EnableTraceLogging;
packageSettings.Save();
}
Expand Down
Loading

0 comments on commit ab1e2b1

Please sign in to comment.