[GHSA-88g2-r9rw-g55h] gitoxide-core does not neutralize special characters for terminals #4925
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Comments
This low-risk vulnerability, tracked in GitoxideLabs/gitoxide#1534, has not yet been patched, but new versions of the affected crates
gitoxide-core
andgitoxide
have been released. This edit bumps their version upper bounds accordingly, to reflect that this is unpatched in all existing versions of those crates.I have already made this change in the repo-level GHSA advisory. No corresponding change is required in the NVD entry or the RUSTSEC advisory, since those do not specify explicit affected-version ranges. So this global GHSA is the only thing that (still) needs to be updated for this.
Although this is not the kind of vulnerability that is likely to go away due to seemingly unrelated changes, to make sure that this edit is correct I have verified experimentally that the vulnerability is still present with the new versions, and that the proof-of-concept procedure in this advisory still succeeds at demonstrating it.
This lists CVSS v3 as having been edited here, but I did not modify that. I believe that is due to changes that have been made in the advisory database itself, and that the same CVSS base scores will be listed both before and after this revision. So I am not worried about that.
(Sometimes, I have observed that edits to advisories that contain complex constructions involving backslashes--including in Markdown code blocks--have resulted in the introduction of additional backslashes, which cause the content to become incorrect, to be made when the changes from the PR are merged, even though the incorrect material has not appeared in the revisions themselves. #4777 details the most recent time I have observed this to occur. My hope is that this will not happen here, since this is only editing metadata. However, I will watch for it and, if it arises, then I will either attempt to fix it or open an issue to request help with it, as was successful in #4777.)